Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores

2014-03-28 Thread Richard Henderson
On 03/28/2014 11:18 AM, Peter Maydell wrote: > On 28 March 2014 18:06, Richard Henderson wrote: >> On 03/28/2014 08:29 AM, Peter Maydell wrote: >>> Peter Maydell (3): >>> exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps >>> tcg: Avoid stores to unaligned addresses >>> tc

Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores

2014-03-28 Thread Peter Maydell
On 28 March 2014 18:06, Richard Henderson wrote: > On 03/28/2014 08:29 AM, Peter Maydell wrote: >> Peter Maydell (3): >> exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps >> tcg: Avoid stores to unaligned addresses >> tcg: Avoid undefined behaviour patching code at unalig

Re: [Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores

2014-03-28 Thread Richard Henderson
On 03/28/2014 08:29 AM, Peter Maydell wrote: > Peter Maydell (3): > exec-all.h: Use stl_p to avoid undefined behaviour patching x86 jumps > tcg: Avoid stores to unaligned addresses > tcg: Avoid undefined behaviour patching code at unaligned addresses Reviewed-by: Richard Henderson r~

[Qemu-devel] [RFC 0/3] tcg: Avoid undefined behaviour on unaligned stores

2014-03-28 Thread Peter Maydell
These patches fix various cases in the x86 backend and the runtime TB-jump-patching code where we cast an unaligned pointer to a uint32_t* and store into it. Unaligned accesses are OK on x86 hardware, of course, but this is still undefined behaviour in C, and the clang sanitizer complains. Sent ou