Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-19 Thread Andrea Bolognani
On Thu, 2017-02-16 at 21:14 +0200, Marcel Apfelbaum wrote: >  > Wait, actually.. we have two possible directions to go, both of which >  > have been mentioned in the thread, but I don't think we've settled on >  > one: >  > >  > 1) Have pseries create a PCIe bus (as my first cut draft does). >  > >

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 05:28 AM, David Gibson wrote: On Thu, Feb 16, 2017 at 01:48:42PM +1100, David Gibson wrote: On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: On 02/15/2017 03:45 AM, David Gibson wrote: On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: On 02/14/20

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 04:48 AM, David Gibson wrote: On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: [...] I did float the idea of having the pseries PCI bus remain plain PCI but with a special flag to allow PCIe devices to be attached to it anyway. It wasn't greeted with much enth

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-15 Thread Gerd Hoffmann
On Di, 2017-02-14 at 14:53 +0200, Marcel Apfelbaum wrote: > I suppose XHCI can behave the same as virtio if Gerd has nothing > against it No objections. cheers, Gerd

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-15 Thread David Gibson
On Thu, Feb 16, 2017 at 01:48:42PM +1100, David Gibson wrote: > On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > > On 02/15/2017 03:45 AM, David Gibson wrote: > > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > > On 02/14/2017 06:15 AM, David Gibson wrot

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-15 Thread David Gibson
On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > On 02/15/2017 03:45 AM, David Gibson wrote: > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > On 02/14/2017 06:15 AM, David Gibson wrote: > > > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-15 Thread Marcel Apfelbaum
On 02/15/2017 03:45 AM, David Gibson wrote: On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: On 02/14/2017 06:15 AM, David Gibson wrote: On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: On 02/13/2017 06:33 AM, David Gibson wrote: On Sun, Feb 12, 2017 at 09:05

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-14 Thread David Gibson
On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > On 02/14/2017 06:15 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: > > > On 02/13/2017 06:33 AM, David Gibson wrote: > > > > On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-14 Thread Marcel Apfelbaum
On 02/14/2017 06:15 AM, David Gibson wrote: On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: On 02/13/2017 06:33 AM, David Gibson wrote: On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum wrote: On 02/10/2017 02:37 AM, David Gibson wrote: On Thu, Feb 09, 2017 at 10:04

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-13 Thread David Gibson
On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: > On 02/13/2017 06:33 AM, David Gibson wrote: > > On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum wrote: > > > On 02/10/2017 02:37 AM, David Gibson wrote: > > > > On Thu, Feb 09, 2017 at 10:04:47AM +0100, Laszlo Ersek wrot

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-13 Thread Marcel Apfelbaum
On 02/13/2017 06:33 AM, David Gibson wrote: On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum wrote: On 02/10/2017 02:37 AM, David Gibson wrote: On Thu, Feb 09, 2017 at 10:04:47AM +0100, Laszlo Ersek wrote: On 02/09/17 05:16, David Gibson wrote: On Wed, Feb 08, 2017 at 11:40:50AM +01

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-12 Thread David Gibson
On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum wrote: > On 02/10/2017 02:37 AM, David Gibson wrote: > > On Thu, Feb 09, 2017 at 10:04:47AM +0100, Laszlo Ersek wrote: > > > On 02/09/17 05:16, David Gibson wrote: > > > > On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: > > >

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-12 Thread Marcel Apfelbaum
On 02/10/2017 02:37 AM, David Gibson wrote: On Thu, Feb 09, 2017 at 10:04:47AM +0100, Laszlo Ersek wrote: On 02/09/17 05:16, David Gibson wrote: On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: On 02/08/17 07:16, David Gibson wrote: Marcel, Your original patch adding PCIe suppor

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-09 Thread David Gibson
On Thu, Feb 09, 2017 at 10:04:47AM +0100, Laszlo Ersek wrote: > On 02/09/17 05:16, David Gibson wrote: > > On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: > >> On 02/08/17 07:16, David Gibson wrote: > >>> Marcel, > >>> > >>> Your original patch adding PCIe support to virtio-pci.c has

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-09 Thread Laszlo Ersek
On 02/09/17 05:16, David Gibson wrote: > On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: >> On 02/08/17 07:16, David Gibson wrote: >>> Marcel, >>> >>> Your original patch adding PCIe support to virtio-pci.c has the >>> limitation noted below that PCIe won't be enabled if the device is

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-08 Thread David Gibson
On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: > On 02/08/17 07:16, David Gibson wrote: > > Marcel, > > > > Your original patch adding PCIe support to virtio-pci.c has the > > limitation noted below that PCIe won't be enabled if the device is on > > the root bus (rather than under a

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-08 Thread Laszlo Ersek
On 02/08/17 07:16, David Gibson wrote: > Marcel, > > Your original patch adding PCIe support to virtio-pci.c has the > limitation noted below that PCIe won't be enabled if the device is on > the root bus (rather than under a root or downstream port). As > reasoned below, I think removing the chec

[Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-07 Thread David Gibson
Marcel, Your original patch adding PCIe support to virtio-pci.c has the limitation noted below that PCIe won't be enabled if the device is on the root bus (rather than under a root or downstream port). As reasoned below, I think removing the check is correct, even for x86 (though it would rarely