Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Peter Lieven
Am 12.03.2013 um 13:02 schrieb Paolo Bonzini : > Il 12/03/2013 12:51, Peter Lieven ha scritto: buffer_is_zero is used in somewhat special cases (block streaming/copy-on-read) where throughput doesn't really matter, unlike is_dup_page/find_zero_bit which are used in migration. But

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Peter Lieven
Am 12.03.2013 um 13:02 schrieb Paolo Bonzini : > Il 12/03/2013 12:51, Peter Lieven ha scritto: buffer_is_zero is used in somewhat special cases (block streaming/copy-on-read) where throughput doesn't really matter, unlike is_dup_page/find_zero_bit which are used in migration. But

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Paolo Bonzini
Il 12/03/2013 12:51, Peter Lieven ha scritto: >> > buffer_is_zero is used in somewhat special cases (block >> > streaming/copy-on-read) where throughput doesn't really matter, unlike >> > is_dup_page/find_zero_bit which are used in migration. But you can use >> > similar code for is_dup_page and b

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Peter Lieven
Am 12.03.2013 um 12:46 schrieb Paolo Bonzini : > Il 12/03/2013 12:20, Peter Lieven ha scritto: >>> * zero pages remain zero, and thus are only processed once >> >> you are right this will be the case. >> >>> >>> * non-zero pages are modified often, and thus are processed multiple times. >>> >

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Paolo Bonzini
Il 12/03/2013 12:20, Peter Lieven ha scritto: >> * zero pages remain zero, and thus are only processed once > > you are right this will be the case. > >> >> * non-zero pages are modified often, and thus are processed multiple times. >> >> Your patch adds overhead in the case where a page is non-z

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Peter Lieven
Am 12.03.2013 um 12:11 schrieb Paolo Bonzini : > Il 12/03/2013 11:51, Peter Lieven ha scritto: >> Hi, >> >> a second patch to optimize live migration. I have generated some >> artifical load >> testing for zero pages. Ordinary dup or non dup pages are not affected. >> >> savings for zero pages

Re: [Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Paolo Bonzini
Il 12/03/2013 11:51, Peter Lieven ha scritto: > Hi, > > a second patch to optimize live migration. I have generated some > artifical load > testing for zero pages. Ordinary dup or non dup pages are not affected. > > savings for zero pages (test case): > non SSE2:30s -> 26s > SSE2:27

[Qemu-devel] [RFC] optimize is_dup_page for zero pages

2013-03-12 Thread Peter Lieven
Hi, a second patch to optimize live migration. I have generated some artifical load testing for zero pages. Ordinary dup or non dup pages are not affected. savings for zero pages (test case): non SSE2:30s -> 26s SSE2:27s -> 21s optionally I would suggest optimizing buffer_is_zero