Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 15:27, Reza Jelveh wrote: > you are extending structure beyond of what specified by ACPI 1.0b spec, > that might break guests. > We probably can't change revision since Windows ACPI implementation > is mostly 1.0b based so we are stuck with it. > Patch needs to b

Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Paolo Bonzini
On 29/03/2015 19:38, Marcel Apfelbaum wrote: > On 03/28/2015 05:46 PM, Reza Jelveh wrote: >> Some operating systems such as FreeBSD and Mac OSX need the >> reset_register >> section of the FADT filled to know which port to write to for a system >> reset. >> >> What is the right way to set the res

Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Igor Mammedov
On Mon, 30 Mar 2015 15:27:26 +0200 Reza Jelveh wrote: > On Mon, Mar 30, 2015 at 2:36 PM, Igor Mammedov wrote: > > > you are extending structure beyond of what specified by ACPI 1.0b spec, > > that might break guests. > > We probably can't change revision since Windows ACPI implementation > > is

Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Reza Jelveh
On Mon, Mar 30, 2015 at 2:36 PM, Igor Mammedov wrote: > you are extending structure beyond of what specified by ACPI 1.0b spec, > that might break guests. > We probably can't change revision since Windows ACPI implementation > is mostly 1.0b based so we are stuck with it. > Patch needs to be test

Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Igor Mammedov
On Sat, 28 Mar 2015 15:46:53 +0100 Reza Jelveh wrote: > Some operating systems such as FreeBSD and Mac OSX need the reset_register > section of the FADT filled to know which port to write to for a system reset. > > What is the right way to set the reset_val and the reset addr in this case? > ---

Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-29 Thread Marcel Apfelbaum
On 03/28/2015 05:46 PM, Reza Jelveh wrote: Some operating systems such as FreeBSD and Mac OSX need the reset_register section of the FADT filled to know which port to write to for a system reset. What is the right way to set the reset_val and the reset addr in this case? --- hw/i386/acpi-build

[Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-28 Thread Reza Jelveh
Some operating systems such as FreeBSD and Mac OSX need the reset_register section of the FADT filled to know which port to write to for a system reset. What is the right way to set the reset_val and the reset addr in this case? --- hw/i386/acpi-build.c | 5 + hw/i386/acpi-defs.h | 2 ++ 2 f