Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-04 Thread Avi Kivity
On 12/04/2011 03:16 PM, Jan Kiszka wrote: > On 2011-12-04 14:12, Avi Kivity wrote: > > On 12/03/2011 01:17 PM, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> Rename msix_supported to msi_supported and control MSI and MSI-X > >> activation this way. That was likely to original intention for this

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-04 Thread Jan Kiszka
On 2011-12-04 14:12, Avi Kivity wrote: > On 12/03/2011 01:17 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Rename msix_supported to msi_supported and control MSI and MSI-X >> activation this way. That was likely to original intention for this >> flag, but MSI support came after MSI-X. > > 'and'

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-04 Thread Avi Kivity
On 12/03/2011 01:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Rename msix_supported to msi_supported and control MSI and MSI-X > activation this way. That was likely to original intention for this > flag, but MSI support came after MSI-X. 'and' is a dangerous word in a changelog entry. > > +

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-04 Thread Jan Kiszka
On 2011-12-04 11:42, Michael S. Tsirkin wrote: > On Sat, Dec 03, 2011 at 12:17:26PM +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Rename msix_supported to msi_supported and control MSI and MSI-X >> activation this way. That was likely to original intention for this >> flag, but MSI support ca

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-04 Thread Michael S. Tsirkin
On Sat, Dec 03, 2011 at 12:17:26PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Rename msix_supported to msi_supported and control MSI and MSI-X > activation this way. That was likely to original intention for this > flag, but MSI support came after MSI-X. > > Signed-off-by: Jan Kiszka Acke

[Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

2011-12-03 Thread Jan Kiszka
From: Jan Kiszka Rename msix_supported to msi_supported and control MSI and MSI-X activation this way. That was likely to original intention for this flag, but MSI support came after MSI-X. Signed-off-by: Jan Kiszka --- hw/msi.c |8 hw/msi.h |2 ++ hw/msix.c |9 -