Re: [Qemu-devel] [RFC/RFT v1 4/8] xilinx: Inline usages of xilinx_intc_create()

2014-01-12 Thread Peter Crosthwaite
Hi Edgar, On Sun, Jan 12, 2014 at 11:32 PM, Edgar E. Iglesias wrote: > On Wed, Jan 01, 2014 at 04:03:06PM -0800, Peter Crosthwaite wrote: >> Inline these usages. Converts these init to at least a semi-recent QOM >> styling. > > Thanks Peter, > > I dont mind the patches but can you clarify the win

Re: [Qemu-devel] [RFC/RFT v1 4/8] xilinx: Inline usages of xilinx_intc_create()

2014-01-12 Thread Edgar E. Iglesias
On Wed, Jan 01, 2014 at 04:03:06PM -0800, Peter Crosthwaite wrote: > Inline these usages. Converts these init to at least a semi-recent QOM > styling. Thanks Peter, I dont mind the patches but can you clarify the win with this? Looks like we are mostly reducing code reusage? A similar patch was

[Qemu-devel] [RFC/RFT v1 4/8] xilinx: Inline usages of xilinx_intc_create()

2014-01-01 Thread Peter Crosthwaite
Inline these usages. Converts these init to at least a semi-recent QOM styling. Signed-off-by: Peter Crosthwaite --- hw/microblaze/petalogix_ml605_mmu.c | 6 +- hw/microblaze/petalogix_s3adsp1800_mmu.c | 7 ++- hw/ppc/virtex_ml507.c| 6 +- include/hw/xili