Re: [Qemu-devel] [RFC/PATCH] monitor/ppc: Access all SPRs from the monitor

2015-10-01 Thread Benjamin Herrenschmidt
On Wed, 2015-09-30 at 12:47 +0100, Peter Maydell wrote: > > const MonitorDef *target_monitor_defs(void); > > +int target_extra_monitor_def(uint64_t *pval, const char *name); > > This would be a good place to put a doc comment documenting > the semantics of this new hook. > > MonitorDef structs

Re: [Qemu-devel] [RFC/PATCH] monitor/ppc: Access all SPRs from the monitor

2015-09-30 Thread Peter Maydell
On 27 September 2015 at 07:31, Benjamin Herrenschmidt wrote: > We already have a table with all supported SPRs along with their names, > so let's use that rather than a duplicate table that is perpetually > out of sync in the monitor code. > > This adds a new monitor hook target_extra_monitor_def(

[Qemu-devel] [RFC/PATCH] monitor/ppc: Access all SPRs from the monitor

2015-09-26 Thread Benjamin Herrenschmidt
We already have a table with all supported SPRs along with their names, so let's use that rather than a duplicate table that is perpetually out of sync in the monitor code. This adds a new monitor hook target_extra_monitor_def() which is called if nothing is found is the normal table. We still use