Re: [Qemu-devel] [RESEND PATCH v2 1/2] seabios q35: Enable all PIRQn IRQs at startup

2013-02-20 Thread Kevin O'Connor
On Fri, Feb 15, 2013 at 02:11:35PM -0700, Alex Williamson wrote: > We seem to use the IRQEN bit of the PIRQn registers interchangeably > to select APIC mode or to disable an IRQ. I can't decide if we're > intending to disable the IRQ or select APIC mode here, but in either > case it prevents PIC m

[Qemu-devel] [RESEND PATCH v2 1/2] seabios q35: Enable all PIRQn IRQs at startup

2013-02-15 Thread Alex Williamson
We seem to use the IRQEN bit of the PIRQn registers interchangeably to select APIC mode or to disable an IRQ. I can't decide if we're intending to disable the IRQ or select APIC mode here, but in either case it prevents PIC mode assigned devices from working. When seabios writes IRQEN to these re