Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-17 Thread Blue Swirl
Thanks, applied. On Tue, Mar 13, 2012 at 06:05, Amos Kong wrote: > VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked > VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), > but we don't check this bit in vmstate_save_state(). > > Signed-off-by: Amos Kong > --- >  savevm.

Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-13 Thread Hervé Poussineau
Amos Kong a écrit : VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), but we don't check this bit in vmstate_save_state(). Signed-off-by: Amos Kong Acked-by: Hervé Poussineau

Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-13 Thread Juan Quintela
Andreas Färber wrote: > Am 13.03.2012 07:05, schrieb Amos Kong: >> VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked >> VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), >> but we don't check this bit in vmstate_save_state(). > > So what were the symptoms? Does this need

Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-13 Thread Andreas Färber
Am 13.03.2012 07:05, schrieb Amos Kong: > VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked > VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), > but we don't check this bit in vmstate_save_state(). So what were the symptoms? Does this need to be backported to stable? A

Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-13 Thread Juan Quintela
Amos Kong wrote: > VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked > VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), > but we don't check this bit in vmstate_save_state(). > > Signed-off-by: Amos Kong Acked-by: Juan Quintela

[Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-12 Thread Amos Kong
VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), but we don't check this bit in vmstate_save_state(). Signed-off-by: Amos Kong --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/save