On 03/20/2017 02:38 PM, Saurav Sachidanand wrote:
Change malloc/strdup/free to g_malloc/g_strdup/g_free in
util/envlist.c.
Remove NULL checks for pointers returned from g_malloc and g_strdup
as they exit in case of failure. Also, update calls to envlist_create
to reflect this.
Free array and ar
On 03/28/2017 10:47 AM, Peter Maydell wrote:
On 28 March 2017 at 14:44, Philippe Mathieu-Daudé wrote:
Hi Saurav,
you should read the QEMU Coding Style and replace your tabs by 4 spaces.
Er, in review comments on v3 we said not to do that...
oops I missed Stefan comment in v2, sorry!
tha
On 28 March 2017 at 14:44, Philippe Mathieu-Daudé wrote:
> Hi Saurav,
>
> you should read the QEMU Coding Style and replace your tabs by 4 spaces.
Er, in review comments on v3 we said not to do that...
thanks
-- PMM
Hi Saurav,
you should read the QEMU Coding Style and replace your tabs by 4 spaces.
On 03/20/2017 02:38 PM, Saurav Sachidanand wrote:
Change malloc/strdup/free to g_malloc/g_strdup/g_free in
util/envlist.c.
Remove NULL checks for pointers returned from g_malloc and g_strdup
as they exit in cas
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in
envlist.c
Message-id: 20170320173828.3874-1-sauravsachidan...@gmail.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin
On Mon, Mar 20, 2017 at 05:38:28PM +, Saurav Sachidanand wrote:
> Change malloc/strdup/free to g_malloc/g_strdup/g_free in
> util/envlist.c.
>
> Remove NULL checks for pointers returned from g_malloc and g_strdup
> as they exit in case of failure. Also, update calls to envlist_create
> to refl
Change malloc/strdup/free to g_malloc/g_strdup/g_free in
util/envlist.c.
Remove NULL checks for pointers returned from g_malloc and g_strdup
as they exit in case of failure. Also, update calls to envlist_create
to reflect this.
Free array and array contents returned by envlist_to_environ using
g_
