Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] util: Use g_malloc/g_free in envlist.c

2017-03-20 Thread Stefan Hajnoczi
On Sun, Mar 19, 2017 at 04:27:15PM +, Saurav Sachidanand wrote: > @@ -48,10 +46,10 @@ envlist_free(envlist_t *envlist) > entry = envlist->el_entries.lh_first; > QLIST_REMOVE(entry, ev_link); > > - free((char *)entry->ev_var); > + g_free(entr

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] util: Use g_malloc/g_free in envlist.c

2017-03-19 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [Qemu-trivial] [PATCH v3] util: Use g_malloc/g_free in envlist.c Message-id: 20170319162715.2260-1-sauravsachidan...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing

[Qemu-devel] [Qemu-trivial] [PATCH v3] util: Use g_malloc/g_free in envlist.c

2017-03-19 Thread Saurav Sachidanand
Change malloc/strdup/free to g_malloc/g_strdup/g_free in util/envlist.c. Remove NULL checks for pointers returned from g_malloc and g_strdup as they exit in case of failure. Also, update calls to envlist_create to reflect this. Free array and array contents returned by envlist_to_environ using g_