Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak

2014-11-01 Thread Michael Tokarev
02.11.2014 08:21, Gonglei wrote: [] > Agree. v2 will do. Thanks! Also, I think it's good idea to add " in net_init_tap" to subject. (And please don't resend both patches, as I already applied first :) Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak

2014-11-01 Thread Gonglei
On 2014/11/2 13:11, Michael Tokarev wrote: > 31.10.2014 09:11, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> In hotplugging scenario, taking those true branch, the file >> handler do not be closed. Adding cleanup logic for them. >> >> Signed-off-by: Gonglei >> --- >> net/tap.c | 12

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak

2014-11-01 Thread Michael Tokarev
31.10.2014 09:11, arei.gong...@huawei.com wrote: > From: Gonglei > > In hotplugging scenario, taking those true branch, the file > handler do not be closed. Adding cleanup logic for them. > > Signed-off-by: Gonglei > --- > net/tap.c | 12 +--- > 1 file changed, 9 insertions(+), 3 delet