Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-31 Thread Arthur Gautier
On Thu, Oct 30, 2014 at 06:27:20PM +0800, Fam Zheng wrote: > On Thu, 10/30 10:09, Arthur Gautier wrote: > > On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > > > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > > > On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > > > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-31 Thread Fam Zheng
On Thu, 10/30 15:28, Arthur Gautier wrote: > On Thu, Oct 30, 2014 at 06:27:20PM +0800, Fam Zheng wrote: > > On Thu, 10/30 10:09, Arthur Gautier wrote: > > > On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > > > > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > > > > On Thu, Oct 23, 2014

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-30 Thread Fam Zheng
On Thu, 10/30 10:09, Arthur Gautier wrote: > On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > > On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > > > > Michael Tokarev writes: > > > > > > > > > On 10/22/2014 05:25 PM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-30 Thread Arthur Gautier
On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > > > Michael Tokarev writes: > > > > > > > On 10/22/2014 05:25 PM, Arthur Gautier wrote: > > > >> We can not rely on int

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-28 Thread Fam Zheng
On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > > Michael Tokarev writes: > > > > > On 10/22/2014 05:25 PM, Arthur Gautier wrote: > > >> We can not rely on int cast to get a correct number of cylinders. The > > >> cylinders inform

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-28 Thread Stefan Hajnoczi
On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > Michael Tokarev writes: > > > On 10/22/2014 05:25 PM, Arthur Gautier wrote: > >> We can not rely on int cast to get a correct number of cylinders. The > >> cylinders information was wrong in 49.% of cases. > >> > >> This en

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-23 Thread Markus Armbruster
Michael Tokarev writes: > On 10/22/2014 05:25 PM, Arthur Gautier wrote: >> We can not rely on int cast to get a correct number of cylinders. The >> cylinders information was wrong in 49.% of cases. >> >> This ensures the cylinders always gets the ceiling value. > > Good thing, especially the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-22 Thread Michael Tokarev
On 10/22/2014 05:25 PM, Arthur Gautier wrote: > We can not rely on int cast to get a correct number of cylinders. The > cylinders information was wrong in 49.% of cases. > > This ensures the cylinders always gets the ceiling value. Good thing, especially the good probability :), and also a go