Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in envlist.c

2017-03-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170304110658.1402-1-sauravsachidan...@gmail.com Subject: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in envlist.c Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in envlist.c

2017-03-04 Thread Saurav Sachidanand
Change malloc/free to g_malloc/g_free in util/envlist.c, except for entry->env_var which is allocated using strdup(3). Remove NULL checks for pointers returned from g_malloc as it exits in case of failure. Update calls to envlist_create to reflect this. Free array returned by envlist_to_environ u