Re: [Qemu-devel] [Qemu-trivial] [PATCH] os-win32.c : fix memory leak

2011-11-28 Thread Stefan Hajnoczi
On Thu, Nov 24, 2011 at 04:27:52PM +0800, Zhi Hui Li wrote: > string is allocated by g_malloc, will not be used after putenv, should be > free before return. > > Signed-off-by: Li Zhi Hui > --- > os-win32.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the triv

Re: [Qemu-devel] [Qemu-trivial] [PATCH] os-win32.c : fix memory leak

2011-11-25 Thread Paolo Bonzini
On 11/24/2011 08:28 PM, Stefan Weil wrote: MS claims that putenv is a POSIX function, so I also expected that free / f_free is not allowed. I now wrote a short test which indicates that g_free would work: getenv returns a pointer which is completely different from the one passed to putenv. Co

Re: [Qemu-devel] [Qemu-trivial] [PATCH] os-win32.c : fix memory leak

2011-11-24 Thread Stefan Weil
Am 24.11.2011 20:28, schrieb Stefan Weil: Am 24.11.2011 11:27, schrieb Stefan Hajnoczi: On Thu, Nov 24, 2011 at 05:15:30PM +0800, Mark wrote: If you free the string, it will cause the environment variable unavailable. More details please see the following text extracted from manual of "puten

Re: [Qemu-devel] [Qemu-trivial] [PATCH] os-win32.c : fix memory leak

2011-11-24 Thread Stefan Weil
Am 24.11.2011 11:27, schrieb Stefan Hajnoczi: On Thu, Nov 24, 2011 at 05:15:30PM +0800, Mark wrote: If you free the string, it will cause the environment variable unavailable. More details please see the following text extracted from manual of "putenv": The libc4 and libc5 and

Re: [Qemu-devel] [Qemu-trivial] [PATCH] os-win32.c : fix memory leak

2011-11-24 Thread Stefan Hajnoczi
On Thu, Nov 24, 2011 at 05:15:30PM +0800, Mark wrote: > If you free the string, it will cause the environment variable unavailable. > More details please see the following text extracted from manual of > "putenv": > >The libc4 and libc5 and glibc 2.1.2 versions conform to SUSv2: > th