Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-27 Thread Paolo Bonzini
Il 15/04/2014 01:55, Michael R. Hines ha scritto: Paolo? I see that some of the block-migration code and the qemu-img code is also calling buffer_is_zero() - are you guys depending on the performance of any buffer_is_zero() calls to use the vector-optimized version like migration does? Yes, def

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-15 Thread 陈梁
> On 04/15/14 01:55, Michael R. Hines wrote: >> On 04/14/2014 05:19 PM, Laszlo Ersek wrote: >>> On 04/14/14 04:27, Amos Kong wrote: We already have a function buffer_is_zero() in util/cutils.c Signed-off-by: Amos Kong --- arch_init.c | 9 ++--- 1 file changed,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-15 Thread Laszlo Ersek
On 04/15/14 01:55, Michael R. Hines wrote: > On 04/14/2014 05:19 PM, Laszlo Ersek wrote: >> On 04/14/14 04:27, Amos Kong wrote: >>> We already have a function buffer_is_zero() in util/cutils.c >>> >>> Signed-off-by: Amos Kong >>> --- >>> arch_init.c | 9 ++--- >>> 1 file changed, 2 insertio

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-14 Thread Michael R. Hines
On 04/14/2014 05:19 PM, Laszlo Ersek wrote: On 04/14/14 04:27, Amos Kong wrote: We already have a function buffer_is_zero() in util/cutils.c Signed-off-by: Amos Kong --- arch_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index