Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test

2018-12-11 Thread Laurent Vivier
Le 10/12/2018 à 20:42, Richard Henderson a écrit : > On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote: >> Hi Fabrice, >> >> On Fri, Dec 7, 2018 at 5:06 PM wrote: >>> >>> As "xchg" reads and writes both operands, the "+m" is required to avoid >>> undefined behavior on -O2 compilation. >>> >>> Sign

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test

2018-12-10 Thread Richard Henderson
On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote: > Hi Fabrice, > > On Fri, Dec 7, 2018 at 5:06 PM wrote: >> >> As "xchg" reads and writes both operands, the "+m" is required to avoid >> undefined behavior on -O2 compilation. >> >> Signed-off-by: Fabrice Desclaux Reviewed-by: Richard Henderson

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fixes i386 xchgq test

2018-12-10 Thread Philippe Mathieu-Daudé
Hi Fabrice, On Fri, Dec 7, 2018 at 5:06 PM wrote: > > As "xchg" reads and writes both operands, the "+m" is required to avoid > undefined behavior on -O2 compilation. > > Signed-off-by: Fabrice Desclaux > --- > tests/tcg/i386/test-i386.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)