Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-23 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 7:11 AM, Stefan Weil wrote: > Am 24.06.2011 07:41, schrieb Stefan Hajnoczi: >> >> On Thu, Jun 23, 2011 at 3:32 PM, Stefan Weil wrote: >>> >>> Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: > > Fro

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-23 Thread Stefan Weil
Am 24.06.2011 07:41, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 3:32 PM, Stefan Weil wrote: Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: From: Jan Kiszka Recent mingw32 provide those defines. ... and all of those defines

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-23 Thread Stefan Hajnoczi
On Thu, Jun 23, 2011 at 3:32 PM, Stefan Weil wrote: > Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: >> >> On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: >>> >>> From: Jan Kiszka >>> >>> Recent mingw32 provide those defines. > > ... and all of those defines are wrong, because QEMU doe

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-23 Thread Stefan Weil
Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: From: Jan Kiszka Recent mingw32 provide those defines. ... and all of those defines are wrong, because QEMU does not use MS format specifiers. http://patchwork.ozlabs.org/patch/74276/ tr

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-23 Thread Stefan Hajnoczi
On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Recent mingw32 provide those defines. > > Signed-off-by: Jan Kiszka > --- > qemu-common.h |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) It's never too late to implement C99! Thanks, applied to