Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 11:52, Peter Lieven wrote: >> >> e4efd8a488d0a68b0af34d8ee245463df7c8bdf4 qemu-timer: initialize >> "timers_done_ev" to set >> 12d69ac03b45156356b240424623719f15d8143e tests: remove irrelevant assertions >> from test-aio >> 6493c975af75be5b8d9ade954239bdf5492b7911 aio-win32: reorg

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Peter Lieven
Am 21.09.2015 um 11:41 schrieb Paolo Bonzini: On 21/09/2015 09:40, Peter Lieven wrote: My backport (Linux only and without tests etc.) of the original fix is here: https://github.com/plieven/qemu/commit/0ddcdc62a85f705017df16421d769e82b70f9b37 Could you be missing edec47c? Indeed this one f

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 09:40, Peter Lieven wrote: >>> >>> >>> My backport (Linux only and without tests etc.) of the original fix >>> is here: >>> https://github.com/plieven/qemu/commit/0ddcdc62a85f705017df16421d769e82b70f9b37 >>> >> Could you be missing edec47c? > > Indeed this one fixed the deadlock wi

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Peter Lieven
Am 07.09.2015 um 21:14 schrieb Paolo Bonzini: On 07/09/2015 21:11, Peter Lieven wrote: It helps, but I have a small issue when my backport of the patch is applied. I launch qemu witch a cmdline like this to probe for enforcable CPU types. echo quit | qemu -enable-kvm -monitor stdio -nodefault

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-07 Thread Peter Lieven
> Am 07.09.2015 um 21:14 schrieb Paolo Bonzini : > > > >> On 07/09/2015 21:11, Peter Lieven wrote: >> It helps, but I have a small issue when my backport of the patch >> is applied. >> >> I launch qemu witch a cmdline like this to probe for enforcable CPU types. >> >> echo quit | qemu -enabl

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-07 Thread Paolo Bonzini
On 07/09/2015 21:11, Peter Lieven wrote: > It helps, but I have a small issue when my backport of the patch > is applied. > > I launch qemu witch a cmdline like this to probe for enforcable CPU types. > > echo quit | qemu -enable-kvm -monitor stdio -nodefaults -nographic -cpu > Haswell,enforce

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-07 Thread Peter Lieven
Am 07.09.2015 um 18:28 schrieb Paolo Bonzini: > > On 03/09/2015 15:11, Peter Lieven wrote: >> edec47c main-loop: fix qemu_notify_event for aio_notify optimization > Part of the above AioContext series. So either the whole series or none of them I guess? >>> It's a separate bug, and the

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-07 Thread Paolo Bonzini
On 03/09/2015 15:11, Peter Lieven wrote: >> > edec47c main-loop: fix qemu_notify_event for aio_notify optimization Part of the above AioContext series. >>> So either the whole series or none of them I guess? >> It's a separate bug, and theoretically it's there in 2.3.1 as well, but >> no

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-03 Thread Peter Lieven
Am 31.07.2015 um 11:29 schrieb Paolo Bonzini: On 31/07/2015 10:35, Peter Lieven wrote: Am 31.07.2015 um 10:22 schrieb Paolo Bonzini: 52c91da memory: do not add a reference to the owner of aliased regions This could be backported, yes. Feel free to send it to qemu-stable. However, the bug was

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-06 Thread Peter Lieven
Am 05.08.2015 um 10:39 schrieb Paolo Bonzini: On 05/08/2015 01:23, ronnie sahlberg wrote: You only get >0 from this call if there are actual bytes available to read. For context, the problem was that 75 static void nfs_process_read(void *arg) 76 { 77 NFSClient *client = arg;

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-05 Thread Paolo Bonzini
On 05/08/2015 01:23, ronnie sahlberg wrote: > > You only get >0 from this call if there are actual bytes available to read. > > For context, the problem was that > > > 75 static void nfs_process_read(void *arg) > 76 { > 77 NFSClient *client = arg; > 78 nfs_service(client->con

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread ronnie sahlberg
On Tue, Aug 4, 2015 at 5:53 AM, Peter Lieven wrote: > Am 04.08.2015 um 14:29 schrieb Peter Lieven: > >> Am 04.08.2015 um 14:09 schrieb Paolo Bonzini: >> >>> >>> On 04/08/2015 13:57, Peter Lieven wrote: >>> Okay, what I found out is that in aio_poll I get revents = POLLIN for the nfs fil

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Michael Roth
Quoting Peter Lieven (2015-07-31 03:35:38) > Am 31.07.2015 um 10:22 schrieb Paolo Bonzini: > > > > On 31/07/2015 10:12, Peter Lieven wrote: > >> Hi Paolo, hi Stefan, > >> > >> you submitted some fixes for 2.4 recently. None of the folloing had > >> qemu-stable in CC. Is this not stable material? >

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 14:29 schrieb Peter Lieven: Am 04.08.2015 um 14:09 schrieb Paolo Bonzini: On 04/08/2015 13:57, Peter Lieven wrote: Okay, what I found out is that in aio_poll I get revents = POLLIN for the nfs file descriptor. But there is no data available on the socket. Does read return 0 o

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 14:09 schrieb Paolo Bonzini: On 04/08/2015 13:57, Peter Lieven wrote: Okay, what I found out is that in aio_poll I get revents = POLLIN for the nfs file descriptor. But there is no data available on the socket. Does read return 0 or EAGAIN? If it returns EAGAIN, the bug is in

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Paolo Bonzini
On 04/08/2015 13:57, Peter Lieven wrote: > > Okay, what I found out is that in aio_poll I get revents = POLLIN for > the nfs file descriptor. But there is no data available on the socket. Does read return 0 or EAGAIN? If it returns EAGAIN, the bug is in the QEMU main loop or the kernel. It sho

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 13:53 schrieb Paolo Bonzini: On 04/08/2015 11:22, Peter Lieven wrote: edec47c main-loop: fix qemu_notify_event for aio_notify optimization Part of the above AioContext series. So either the whole series or none of them I guess? It's a separate bug, and theoretically it's the

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Paolo Bonzini
On 04/08/2015 11:22, Peter Lieven wrote: > edec47c main-loop: fix qemu_notify_event for aio_notify optimization Part of the above AioContext series. >>> So either the whole series or none of them I guess? >> It's a separate bug, and theoretically it's there in 2.3.1 as well, but >> no on

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 31.07.2015 um 11:29 schrieb Paolo Bonzini: On 31/07/2015 10:35, Peter Lieven wrote: Am 31.07.2015 um 10:22 schrieb Paolo Bonzini: 52c91da memory: do not add a reference to the owner of aliased regions This could be backported, yes. Feel free to send it to qemu-stable. However, the bug was