Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-25 Thread sundeep subbaraya
Hi Alistair, On Mon, Apr 24, 2017 at 11:23 PM, Alistair Francis wrote: >>> >>> Instead of calling all of these in the init function you should split >>> it up over the machines init and realize function. >>> >>> Look at the stm32f205_soc or xlnx-zynqmp files for examples of how to do >>> this. >

Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-24 Thread Alistair Francis
>> >> Instead of calling all of these in the init function you should split >> it up over the machines init and realize function. >> >> Look at the stm32f205_soc or xlnx-zynqmp files for examples of how to do >> this. >> >> It also moves away from calling qdev_create() and qdev_init_nofail() >> an

Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-17 Thread sundeep subbaraya
Hii Alistair, On Sat, Apr 15, 2017 at 2:42 AM, Alistair Francis wrote: > On Sun, Apr 9, 2017 at 4:19 AM, Subbaraya Sundeep > wrote: >> Emulated Emcraft's Smartfusion2 System On Module starter >> kit. >> >> Signed-off-by: Subbaraya Sundeep > > Hey Sundeep, > > Cool patch, I have some comments be

Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-14 Thread Alistair Francis
On Sun, Apr 9, 2017 at 4:19 AM, Subbaraya Sundeep wrote: > Emulated Emcraft's Smartfusion2 System On Module starter > kit. > > Signed-off-by: Subbaraya Sundeep Hey Sundeep, Cool patch, I have some comments below. > --- > default-configs/arm-softmmu.mak | 1 + > hw/arm/Makefile.objs

[Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-09 Thread Subbaraya Sundeep
Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 2 +- hw/arm/msf2_soc.c | 141 3 files changed, 143 insertions(+)