Hi Philippe,
On 6/6/2019 4:18 PM, Philippe Mathieu-Daudé wrote:
On 6/5/19 9:15 PM, Lidong Chen wrote:
The check for poll_fds in g_assert() was incorrect. The correct assertion
should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
subsequent for-loop is doing access to poll_fds[
On 6/5/19 9:15 PM, Lidong Chen wrote:
> The check for poll_fds in g_assert() was incorrect. The correct assertion
> should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
> subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i
> is in [0, w->num).
>
> Signed-off-b
You neglected to cc: the file's maintainer. I'm doing that for you now.
In the future, use scripts/get_maintainer.pl to find maintainers you
might want to cc:.
Lidong Chen writes:
> The check for poll_fds in g_assert() was incorrect. The correct assertion
> should check "n_poll_fds + w->num <=
The check for poll_fds in g_assert() was incorrect. The correct assertion
should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i
is in [0, w->num).
Signed-off-by: Lidong Chen
Suggested-by: Peter Maydell
Sugge
On 6/5/2019 1:57 AM, Philippe Mathieu-Daudé wrote:
This patch doesn't seem related to the series cover.
I will resent the patch to include more details to the cover.
On 6/5/19 8:21 AM, Lidong Chen wrote:
The check for poll_fds in g_assert() was incorrect. The correct assertion
should check
This patch doesn't seem related to the series cover.
On 6/5/19 8:21 AM, Lidong Chen wrote:
> The check for poll_fds in g_assert() was incorrect. The correct assertion
> should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
> subsequent for-loop is doing access to poll_fds[n_poll_f
Lidong Chen 于2019年6月5日周三 下午2:23写道：
> The check for poll_fds in g_assert() was incorrect. The correct assertion
> should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
> subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i
> is in [0, w->num).
>
> Signed-off-by:
The check for poll_fds in g_assert() was incorrect. The correct assertion
should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the
subsequent for-loop is doing access to poll_fds[n_poll_fds + i] where i
is in [0, w->num).
Signed-off-by: Lidong Chen
Reviewed-by: Liran Alon
Reviewed-
