Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-12 Thread Fam Zheng
On Wed, 04/12 10:59, Kevin Wolf wrote: > Am 12.04.2017 um 10:42 hat Fam Zheng geschrieben: > > On Tue, 04/11 15:30, Kevin Wolf wrote: > > > Am 11.04.2017 um 15:14 hat Eric Blake geschrieben: > > > > On 04/11/2017 07:05 AM, Kevin Wolf wrote: > > > > > Note that job completion/cancellation aren't syn

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-12 Thread Kevin Wolf
Am 12.04.2017 um 10:42 hat Fam Zheng geschrieben: > On Tue, 04/11 15:30, Kevin Wolf wrote: > > Am 11.04.2017 um 15:14 hat Eric Blake geschrieben: > > > On 04/11/2017 07:05 AM, Kevin Wolf wrote: > > > > Note that job completion/cancellation aren't synchronous QMP commands. > > > > The job works some

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-12 Thread Fam Zheng
On Tue, 04/11 15:30, Kevin Wolf wrote: > Am 11.04.2017 um 15:14 hat Eric Blake geschrieben: > > On 04/11/2017 07:05 AM, Kevin Wolf wrote: > > > Note that job completion/cancellation aren't synchronous QMP commands. > > > The job works something like this, where '...' means that the VM can run > > >

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-11 Thread Kevin Wolf
Am 11.04.2017 um 15:14 hat Eric Blake geschrieben: > On 04/11/2017 07:05 AM, Kevin Wolf wrote: > > Note that job completion/cancellation aren't synchronous QMP commands. > > The job works something like this, where '...' means that the VM can run > > and submit new writes etc.: > > > > 1. Start jo

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-11 Thread Eric Blake
On 04/11/2017 07:05 AM, Kevin Wolf wrote: > > Note that job completion/cancellation aren't synchronous QMP commands. > The job works something like this, where '...' means that the VM can run > and submit new writes etc.: > > 1. Start job: mirror_start > ... > 2. Bulk has completed: BLOCK_JOB_RE

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-11 Thread Kevin Wolf
Am 03.04.2017 um 22:29 hat John Snow geschrieben: > On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: > > While debugging some other issue, I happened to stumble across an old > > libvirt commit[*] that adds support for pivot (whether QEMU should > > switch to a target copy or not) operation as a re

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-11 Thread Kashyap Chamarthy
On Tue, Apr 11, 2017 at 11:42:28AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 04/04/2017 08:28 AM, Kashyap Chamarthy wrote: > > > >>> Minor or not, it is a useful viewpoint. Either way, as long as the new > >>> way of getting a transactional non-pivot successful completion is >

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-11 Thread Markus Armbruster
Eric Blake writes: > On 04/04/2017 08:28 AM, Kashyap Chamarthy wrote: > >>> Minor or not, it is a useful viewpoint. Either way, as long as the new >>> way of getting a transactional non-pivot successful completion is >>> something that libvirt can learn via introspection, >> >> Can you elaborat

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-04 Thread Eric Blake
On 04/04/2017 08:28 AM, Kashyap Chamarthy wrote: >> Minor or not, it is a useful viewpoint. Either way, as long as the new >> way of getting a transactional non-pivot successful completion is >> something that libvirt can learn via introspection, > > Can you elaborate a little more on the above,

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-04 Thread Kashyap Chamarthy
On Mon, Apr 03, 2017 at 03:38:36PM -0500, Eric Blake wrote: > On 04/03/2017 03:29 PM, John Snow wrote: > > On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: [...] > >> "[...] There may be potential improvements to the snapshot code to > >> exploit block copy over multiple disks all at one

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-03 Thread Eric Blake
On 04/03/2017 03:29 PM, John Snow wrote: > > > On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: >> While debugging some other issue, I happened to stumble across an old >> libvirt commit[*] that adds support for pivot (whether QEMU should >> switch to a target copy or not) operation as a result o

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-03 Thread John Snow
On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: > While debugging some other issue, I happened to stumble across an old > libvirt commit[*] that adds support for pivot (whether QEMU should > switch to a target copy or not) operation as a result of issuing QMP > 'block-job-cancel' to a 'drive-mir

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-03 Thread Stefan Hajnoczi
On Tue, Mar 28, 2017 at 05:29:34PM +0200, Kashyap Chamarthy wrote: > On Tue, Mar 28, 2017 at 09:49:40AM -0500, Eric Blake wrote: > > On 03/24/2017 07:34 AM, Kashyap Chamarthy wrote: > > > While debugging some other issue, I happened to stumble across an old > > > libvirt commit[*] that adds support