Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2019-01-25 Thread Max Reitz
On 23.01.19 18:47, John Snow wrote: > > > On 1/23/19 12:34 PM, Max Reitz wrote: >> On 23.01.19 14:05, Max Reitz wrote: >>> On 21.01.19 21:50, John Snow wrote: >> >> [...] >> I guess my only other observation is that we have a lot of "while True" loops now, is it worth creating some kind

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2019-01-23 Thread John Snow
On 1/23/19 12:34 PM, Max Reitz wrote: > On 23.01.19 14:05, Max Reitz wrote: >> On 21.01.19 21:50, John Snow wrote: > > [...] > >>> I guess my only other observation is that we have a lot of "while True" >>> loops now, is it worth creating some kind of helper that does the dirty >>> work of fin

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2019-01-23 Thread Max Reitz
On 23.01.19 14:05, Max Reitz wrote: > On 21.01.19 21:50, John Snow wrote: [...] >> I guess my only other observation is that we have a lot of "while True" >> loops now, is it worth creating some kind of helper that does the dirty >> work of finding a serviceable port or nah? > > Seems reasonable

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2019-01-23 Thread Max Reitz
On 21.01.19 21:50, John Snow wrote: > > > On 12/21/18 6:47 PM, Max Reitz wrote: >> To do this, we need to allow creating the NBD server on various ports >> instead of a single one (which may not even work if you run just one >> instance, because something entirely else might be using that port).

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2019-01-21 Thread John Snow
On 12/21/18 6:47 PM, Max Reitz wrote: > To do this, we need to allow creating the NBD server on various ports > instead of a single one (which may not even work if you run just one > instance, because something entirely else might be using that port). > > So we just pick a random port in [32768