Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-20 Thread Kevin Wolf
Am 18.05.2019 um 03:49 hat Heitke, Kenneth geschrieben: > > > On 5/17/2019 12:24 AM, Klaus Birkelund wrote: > > On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: > > > Hi Kenneth, > > > > > > On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: > > > > Hi Klaus, thank

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-18 Thread Klaus Birkelund
On Fri, May 17, 2019 at 07:49:18PM -0600, Heitke, Kenneth wrote: > > > > > > +if (qemu_iovec_from_buf(&iov, 0, ptr, len) != len) { > > > > > > > > > > This should be `qemu_iovec_to_buf`. > > > > > > > > > > > > > This function is transferring data from the "host" to the device so I > > >

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-17 Thread Heitke, Kenneth
On 5/17/2019 12:24 AM, Klaus Birkelund wrote: On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund w

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-17 Thread Heitke, Kenneth
On 5/17/2019 12:24 AM, Klaus Birkelund wrote: On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund w

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Klaus Birkelund
On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: > Hi Kenneth, > > On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: > > Hi Klaus, thank you for you review. I have one comment inline > > > > On 5/14/2019 12:02 AM, Klaus Birkelund wrote: > > > On Fri, Apr 05, 2019 at

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Klaus Birkelund
Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: > Hi Klaus, thank you for you review. I have one comment inline > > On 5/14/2019 12:02 AM, Klaus Birkelund wrote: > > On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: > > > Signed-off-by: Kenneth Heitke >

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Heitke, Kenneth
Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund wrote: On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: Signed-off-by: Kenneth Heitke --- hw/block/nvme.c | 120 +- hw/block/nvme

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-14 Thread Klaus Birkelund
On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: > Signed-off-by: Kenneth Heitke > --- > hw/block/nvme.c | 120 +- > hw/block/nvme.h | 3 ++ > hw/block/trace-events | 2 + > include/block/nvme.h | 2 + > 4 files changed, 12

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-13 Thread John Snow
On 4/9/19 9:19 AM, Stefan Hajnoczi wrote: > On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: >> Signed-off-by: Kenneth Heitke >> --- >> hw/block/nvme.c | 120 +- >> hw/block/nvme.h | 3 ++ >> hw/block/trace-events | 2 + >>

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-04-09 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: > Signed-off-by: Kenneth Heitke > --- > hw/block/nvme.c | 120 +- > hw/block/nvme.h | 3 ++ > hw/block/trace-events | 2 + > include/block/nvme.h | 2 + > 4 files changed, 12