Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Gabriel L. Somlo
On Tue, Apr 22, 2014 at 06:16:53PM +0200, Markus Armbruster wrote: > >> 1. smbios_entry_add() gets called for every "-smbios file=..." and > >> "-smbios type=..." command line argument > >> > >> a. "type=..." is OK, we just remember the values for later > >> > >> b. "file=.

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Markus Armbruster
Gerd Hoffmann writes: > On Di, 2014-04-22 at 09:01 -0400, Gabriel L. Somlo wrote: >> On Tue, Apr 22, 2014 at 08:42:29AM +0200, Gerd Hoffmann wrote: >> > acpi is pretty much in the same boat ... >> > >> > /me looks ... >> > >> > Ah, there is a notifier where you (hopefully) can hook in easily: >

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Gerd Hoffmann
On Di, 2014-04-22 at 09:01 -0400, Gabriel L. Somlo wrote: > On Tue, Apr 22, 2014 at 08:42:29AM +0200, Gerd Hoffmann wrote: > > acpi is pretty much in the same boat ... > > > > /me looks ... > > > > Ah, there is a notifier where you (hopefully) can hook in easily: > > pc_guest_info_machine_done (s

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Gabriel L. Somlo
On Tue, Apr 22, 2014 at 08:42:29AM +0200, Gerd Hoffmann wrote: > acpi is pretty much in the same boat ... > > /me looks ... > > Ah, there is a notifier where you (hopefully) can hook in easily: > pc_guest_info_machine_done (see hw/i386/pc.c). Not sure this can help me though. The order in which

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-21 Thread Gerd Hoffmann
Hi, > Command line options are processed before machine types are > initialized. acpi is pretty much in the same boat ... /me looks ... Ah, there is a notifier where you (hopefully) can hook in easily: pc_guest_info_machine_done (see hw/i386/pc.c). cheers, Gerd

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-17 Thread Gabriel L. Somlo
On Thu, Apr 17, 2014 at 10:31:15AM +0200, Gerd Hoffmann wrote: > > OK, so right now I'm parsing the "version" argument to what is > > currently smbios_set_type1_defaults() (and will become > > smbios_set_defaults() after patching). > > No, don't parse stuff please. Have a look at pc_piix.c, how >

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-17 Thread Gerd Hoffmann
On Mi, 2014-04-16 at 17:02 -0400, Gabriel L. Somlo wrote: > OK, so I have the "legacy" (field-by-field, types 0 and 1 only) code > back in, right next to the new aggregate-smbios-table-plus-entrypoint > code, tested and apparently working fine. > > Before I get carried away with "git rebase", do w

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-16 Thread Gabriel L. Somlo
OK, so I have the "legacy" (field-by-field, types 0 and 1 only) code back in, right next to the new aggregate-smbios-table-plus-entrypoint code, tested and apparently working fine. Before I get carried away with "git rebase", do we still want to go through the whole patch sequence of generating ag

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-16 Thread Gerd Hoffmann
On Di, 2014-04-15 at 20:47 -0400, Kevin O'Connor wrote: > On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > > Leave the old interface code basically as-is. type0 and type1 > > individual fields are passed like they are passed today. We don't > > change to to pass full tables, and w

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Gerd Hoffmann
Hi, > Add "void smbios_get_tables()" as a separate function to generate the > entry point and aggregate smbios table, and then: > >if "machine_type < 2.1" then > > insert smbios_get_table() into fw_cfg (compat mode) > >else > > insert smbios_get_tables() blob + entry poin

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Markus Armbruster
"Kevin O'Connor" writes: > On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: >> Leave the old interface code basically as-is. type0 and type1 >> individual fields are passed like they are passed today. We don't >> change to to pass full tables, and we don't extend that to new table

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Kevin O'Connor
On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > Leave the old interface code basically as-is. type0 and type1 > individual fields are passed like they are passed today. We don't > change to to pass full tables, and we don't extend that to new table > types. Continue to provide t

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Gabriel L. Somlo
On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > So, how about this plan: > > Leave the old interface code basically as-is. type0 and type1 > individual fields are passed like they are passed today. We don't > change to to pass full tables, and we don't extend that to new table >

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-15 Thread Gerd Hoffmann
On Mo, 2014-04-14 at 16:54 -0400, Gabriel L. Somlo wrote: > New in version 6 of the patch set: > > - down to 17 patches (squashed adding spec v2.4 fields > in together with adding v2.8 fields further down). > > - switching to monolithic aggregate tables plus entry point > in patch 11/

[Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-14 Thread Gabriel L. Somlo
New in version 6 of the patch set: - down to 17 patches (squashed adding spec v2.4 fields in together with adding v2.8 fields further down). - switching to monolithic aggregate tables plus entry point in patch 11/17, right after accomplishing full SeaBIOS compatibility (in 10/17).