Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-13 Thread Manos Pitsidianakis
On Mon, Jun 12, 2017 at 01:15:43PM +0200, Kevin Wolf wrote: Am 08.06.2017 um 20:21 hat Manos Pitsidianakis geschrieben: to maintain compatibility with the existing interfaces. We will have to automatically insert or remove new nodes if 'block_set_io_throttle' is used, but let's not extend it. It

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-13 Thread Stefan Hajnoczi
On Mon, Jun 12, 2017 at 02:37:34PM +0200, Alberto Garcia wrote: > On Fri 09 Jun 2017 06:06:09 PM CEST, Manos Pitsidianakis wrote: > > >>> -drive file=foo.qcow2,throttling.group=bar \ > >>> -object throttle-group,iops-total=100,id=bar > >> > >>, and I guess the name would be throttling-grou

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote: > Users can hotplug ThrottleGroups with object-add in QMP/HMP, then > attach drives to a throttle group (ie adding a filter node in the drive path > that points to that throttle group) with an 'attach-throttle' and detach > with '

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote: > The old interface will be retained as much as possible. I think "retained" means "reused" here but in case it doesn't: The old interface must remain 100% functional. Existing software like libvirt must continue to work withou

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Alberto Garcia
On Fri 09 Jun 2017 06:06:09 PM CEST, Manos Pitsidianakis wrote: >>> -drive file=foo.qcow2,throttling.group=bar \ >>> -object throttle-group,iops-total=100,id=bar >> >>, and I guess the name would be throttling-group? > > Hm, I thought throttle-group would be nicer because it's shorter, but

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-12 Thread Kevin Wolf
Am 08.06.2017 um 20:21 hat Manos Pitsidianakis geschrieben: > In continuation of the discussion at [0], here follows a proposal > for a new ThrottleGroup object defined through QOM. > > Throttle groups are currently defined when instantiating a drive in > the command line,, eg. -drive > file=foo.

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-09 Thread Manos Pitsidianakis
On Fri, Jun 09, 2017 at 03:42:41PM +0200, Alberto Garcia wrote: Hey Manos, thanks for your proposal and for the good work :) On Thu 08 Jun 2017 08:21:13 PM CEST, Manos Pitsidianakis wrote: As part of my GSoC project, IO throttling is moved to a block filter driver, which means multiple filter

Re: [Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-09 Thread Alberto Garcia
Hey Manos, thanks for your proposal and for the good work :) On Thu 08 Jun 2017 08:21:13 PM CEST, Manos Pitsidianakis wrote: > As part of my GSoC project, IO throttling is moved to a block filter > driver, which means multiple filter nodes sharing ThrottleGroup > instances, and also, chaining f

[Qemu-devel] [Proposal] I/O throttling through new -object interface

2017-06-08 Thread Manos Pitsidianakis
In continuation of the discussion at [0], here follows a proposal for a new ThrottleGroup object defined through QOM. Throttle groups are currently defined when instantiating a drive in the command line,, eg. -drive file=foo.qcow2,throttling.iops-total=100,throttling.group=bar and also on QM