Re: [Qemu-devel] [Patch] set boot sequence from command line - Take 2

2007-10-25 Thread Dan Kenigsberg
On Thu, Oct 25, 2007 at 10:49:25AM +0200, Bernhard Kauer wrote: > It is perhaps not the best idea to read behind the > end of the boot_device string. It would be safer to > declare boot_device as 'static char boot_device[4]' > and use a strncpy. > > > Bernhard > Thanks for the good catch!

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-25 Thread Bernhard Kauer
It is perhaps not the best idea to read behind the end of the boot_device string. It would be safer to declare boot_device as 'static char boot_device[4]' and use a strncpy. Bernhard > diff --git a/hw/pc.c b/hw/pc.c > index a0c824f..3c552ff 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > +

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread J. Mayer
On Wed, 2007-10-24 at 23:59 +0200, andrzej zaborowski wrote: > On 24/10/2007, Dan Kenigsberg <[EMAIL PROTECTED]> wrote: > > Real PCs try to boot from a CD, then try the hard drive, and finally go > > to the network. And they let their owner change that order. > > With the difference that on real

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread andrzej zaborowski
On 24/10/2007, Dan Kenigsberg <[EMAIL PROTECTED]> wrote: > Real PCs try to boot from a CD, then try the hard drive, and finally go > to the network. And they let their owner change that order. With the difference that on real PCs this is controlled by the BIOS menu rather than a hardware switch, b

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread Daniel P. Berrange
On Wed, Oct 24, 2007 at 04:41:20PM -0500, Anthony Liguori wrote: > Dan Kenigsberg wrote: > >Real PCs try to boot from a CD, then try the hard drive, and finally go > >to the network. And they let their owner change that order. > >This patch lets Qemu do the same with "-boot dcn". > > > >I'll be hap

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread Anthony Liguori
Dan Kenigsberg wrote: Real PCs try to boot from a CD, then try the hard drive, and finally go to the network. And they let their owner change that order. This patch lets Qemu do the same with "-boot dcn". I'll be happy to hear comments about it, Looks good to me. I wrote a very similar pat

Re: [Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread Laurent Vivier
Dan Kenigsberg a écrit : Real PCs try to boot from a CD, then try the hard drive, and finally go to the network. And they let their owner change that order. This patch lets Qemu do the same with "-boot dcn". I'll be happy to hear comments about it, Personally, I think it's a very good idea. L

[Qemu-devel] [Patch] set boot sequence from command line

2007-10-24 Thread Dan Kenigsberg
Real PCs try to boot from a CD, then try the hard drive, and finally go to the network. And they let their owner change that order. This patch lets Qemu do the same with "-boot dcn". I'll be happy to hear comments about it, Dan. diff --git a/hw/an5206.c b/hw/an5206.c index 94ecccb..2134184 10064