On 2015/6/23 14:55, Markus Armbruster wrote:
> Gonglei writes:
>
>> On 2015/6/21 5:10, Paolo Bonzini wrote:
>>>
>>>
>>> On 01/06/2015 14:25, Michael S. Tsirkin wrote:
+static uint64_t qdev_get_prop_mask64(Property *prop)
+{
+assert(prop->info == &qdev_prop_bit);
+retur
Gonglei writes:
> On 2015/6/21 5:10, Paolo Bonzini wrote:
>>
>>
>> On 01/06/2015 14:25, Michael S. Tsirkin wrote:
>>> +static uint64_t qdev_get_prop_mask64(Property *prop)
>>> +{
>>> +assert(prop->info == &qdev_prop_bit);
>>> +return 0x1 << prop->bitnr;
>>
>> This needs to be 1ull.
>>
On 2015/6/21 5:10, Paolo Bonzini wrote:
>
>
> On 01/06/2015 14:25, Michael S. Tsirkin wrote:
>> +static uint64_t qdev_get_prop_mask64(Property *prop)
>> +{
>> +assert(prop->info == &qdev_prop_bit);
>> +return 0x1 << prop->bitnr;
>
> This needs to be 1ull.
>
Yes, and coverity spot it and
On 01/06/2015 14:25, Michael S. Tsirkin wrote:
> +static uint64_t qdev_get_prop_mask64(Property *prop)
> +{
> +assert(prop->info == &qdev_prop_bit);
> +return 0x1 << prop->bitnr;
This needs to be 1ull.
Paolo
> +}
> +
From: Gerd Hoffmann
Needed for virtio features which go from 32bit to 64bit with virtio 1.0
Signed-off-by: Gerd Hoffmann
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/qdev-properties.h | 10
hw/core/qdev-properties.c| 58 +++
