Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-21 Thread Vladimir Sementsov-Ogievskiy
21.08.2017 13:11, Vladimir Sementsov-Ogievskiy wrote: 15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but d

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-21 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-16 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 19:51, Eric Blake wrote: On 08/15/2017 10:50 AM, Vladimir Sementsov-Ogievskiy wrote: 15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
On 08/15/2017 10:50 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2017 18:09, Eric Blake wrote: >> When we switched NBD to use coroutines for qemu 2.9 (in particular, >> commit a12a712a), we introduced a regression: if a server sends us >> garbage (such as a corrupted magic number), we quit the r

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

[Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting in the client hanging when it never rea