Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-21 Thread Wolfgang Bumiller
On Thu, Sep 20, 2018 at 06:14:11PM +0200, Markus Armbruster wrote: > Wolfgang Bumiller writes: > > > On Thu, Sep 20, 2018 at 04:10:00PM +0800, Peter Xu wrote: > >> On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: > >> > >> > Either way, spawning the iothread on demand can still

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Thu, Sep 20, 2018 at 04:10:00PM +0800, Peter Xu wrote: >> On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: >> >> > Either way, spawning the iothread on demand can still make sense, as >> > does updating the check in resume()/suspend(). >> >> Yep.

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Thu, Sep 20, 2018 at 04:10:00PM +0800, Peter Xu wrote: >> On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: >> > On Thu, Sep 20, 2018 at 10:59:56AM +0800, Peter Xu wrote: >> > > On Wed, Sep 19, 2018 at 04:58:06PM +0200, Wolfgang Bumiller wrote: >> >

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Wolfgang Bumiller
On Thu, Sep 20, 2018 at 04:10:00PM +0800, Peter Xu wrote: > On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: > > > Either way, spawning the iothread on demand can still make sense, as > > does updating the check in resume()/suspend(). > > Yep. Running into an issue with that ap

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Wolfgang Bumiller
On Thu, Sep 20, 2018 at 04:10:00PM +0800, Peter Xu wrote: > On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: > > On Thu, Sep 20, 2018 at 10:59:56AM +0800, Peter Xu wrote: > > > On Wed, Sep 19, 2018 at 04:58:06PM +0200, Wolfgang Bumiller wrote: > > > > On Wed, Sep 19, 2018 at 03:36

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Peter Xu
On Thu, Sep 20, 2018 at 10:02:22AM +0200, Wolfgang Bumiller wrote: > On Thu, Sep 20, 2018 at 10:59:56AM +0800, Peter Xu wrote: > > On Wed, Sep 19, 2018 at 04:58:06PM +0200, Wolfgang Bumiller wrote: > > > On Wed, Sep 19, 2018 at 03:36:02PM +0200, Markus Armbruster wrote: > > > > Peter Xu writes: >

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-20 Thread Wolfgang Bumiller
On Thu, Sep 20, 2018 at 10:59:56AM +0800, Peter Xu wrote: > On Wed, Sep 19, 2018 at 04:58:06PM +0200, Wolfgang Bumiller wrote: > > On Wed, Sep 19, 2018 at 03:36:02PM +0200, Markus Armbruster wrote: > > > Peter Xu writes: > > > > Indeed. So we have these ordering constraints: > > > > > > > > ini

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-19 Thread Peter Xu
On Wed, Sep 19, 2018 at 04:58:06PM +0200, Wolfgang Bumiller wrote: > On Wed, Sep 19, 2018 at 03:36:02PM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: > > >> On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbrus

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-19 Thread Wolfgang Bumiller
On Wed, Sep 19, 2018 at 03:36:02PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: > >> On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > >> > From: Peter Xu > >> > > >> > Before this patch, monitor f

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-19 Thread Markus Armbruster
Peter Xu writes: > On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: >> On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: >> > From: Peter Xu >> > >> > Before this patch, monitor fd helpers might be called even earlier than >> > monitor_init_globals(). This ca

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-05 Thread Peter Xu
On Wed, Sep 05, 2018 at 05:05:10PM +0200, Wolfgang Bumiller wrote: > On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > > From: Peter Xu > > > > Before this patch, monitor fd helpers might be called even earlier than > > monitor_init_globals(). This can be problematic. > > > >

Re: [Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-09-05 Thread Wolfgang Bumiller
On Mon, Jun 18, 2018 at 04:08:53PM +0200, Markus Armbruster wrote: > From: Peter Xu > > Before this patch, monitor fd helpers might be called even earlier than > monitor_init_globals(). This can be problematic. > > After previous work, now monitor_init_globals() does not depend on > accelerator

[Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-06-18 Thread Markus Armbruster
From: Peter Xu Before this patch, monitor fd helpers might be called even earlier than monitor_init_globals(). This can be problematic. After previous work, now monitor_init_globals() does not depend on accelerator initialization any more. Call it earlier (before CLI parsing; that's where the