Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-28 Thread Yi Zhang
On 2018-08-24 at 20:14:37 +0300, Michael S. Tsirkin wrote: > On Fri, Aug 24, 2018 at 05:57:06PM +0100, Peter Maydell wrote: > > On 24 August 2018 at 17:53, Michael S. Tsirkin wrote: > > > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: > > >> object_get_canonical_path_component() re

Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2018 at 05:57:06PM +0100, Peter Maydell wrote: > On 24 August 2018 at 17:53, Michael S. Tsirkin wrote: > > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: > >> object_get_canonical_path_component() returns a string which > >> must be freed using g_free(). > > > Like

Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-24 Thread Peter Maydell
On 24 August 2018 at 17:53, Michael S. Tsirkin wrote: > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: >> object_get_canonical_path_component() returns a string which >> must be freed using g_free(). > Like the following? Junyan, could you pls try this one and confirm? > > Signed-

Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: > On 20 August 2018 at 21:24, Michael S. Tsirkin wrote: > > From: Junyan He > > > > When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it > > needs to know whether the backend storage is a real persistent memory, > > in o

Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-24 Thread Peter Maydell
On 20 August 2018 at 21:24, Michael S. Tsirkin wrote: > From: Junyan He > > When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it > needs to know whether the backend storage is a real persistent memory, > in order to decide whether special operations should be performed to > ensure t

[Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-20 Thread Michael S. Tsirkin
From: Junyan He When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it needs to know whether the backend storage is a real persistent memory, in order to decide whether special operations should be performed to ensure the data persistence. This boolean option 'pmem' allows users to s