This was my original intention, but I noticed that structs defined
differently and standard one may be bigger depending on some #defines. So I
renamed in6_addr to in6_address in include/net/eth.h (see v2 patch I sent
yesterday). In case qemu version is not supposed to be a different struct,
then yo
On Sat, Oct 19, 2013 at 12:08:14AM +0400, Dmitry Krivenok wrote:
> > Duplicate, we already have is_multicast_ether_addr() in include/net/eth.h
>
> I tried to #include "net/eth.h" in net/net.c, but it didn't work:
>
> diff --git a/net/net.c b/net/net.c
> index c330c9a..870d3bb 100644
> --- a/net/n
> Duplicate, we already have is_multicast_ether_addr() in include/net/eth.h
I tried to #include "net/eth.h" in net/net.c, but it didn't work:
diff --git a/net/net.c b/net/net.c
index c330c9a..870d3bb 100644
--- a/net/net.c
+++ b/net/net.c
@@ -27,6 +27,7 @@
#include "clients.h"
#include "hub.h"
> Scratch what I said about bit 0 and bit 1, this function is using '%' not
> '&'.
>
> But we should still respin to use the existing function in eth.h.
This is my first qemu patch, so sorry for inconsistent style and
reinventing the wheel.
I'll re-use existing function and send new patch.
Thanks!
On Fri, Oct 18, 2013 at 10:56:55PM +0800, Amos Kong wrote:
> On Fri, Oct 18, 2013 at 03:35:14PM +0200, Stefan Hajnoczi wrote:
> > From: Dmitry Krivenok
> >
> > Added explicit check of MAC address specified via macaddr option.
> > Multicast MAC addresses are no longer allowed.
> > This fixes bug l
On 10/18/2013 10:34 AM, Stefan Hajnoczi wrote:
>>> +
>>> +bool net_macaddr_is_multicast(uint8_t *macaddr)
>>> +{
>>> +return macaddr[0] % 2;
>>> +}
>>
>> Duplicate, we already have is_multicast_ether_addr() in include/net/eth.h
>
> And net_macaddr_is_multicast() is wrong:
> bit 0 is the unica
On Fri, Oct 18, 2013 at 10:56:55PM +0800, Amos Kong wrote:
> On Fri, Oct 18, 2013 at 03:35:14PM +0200, Stefan Hajnoczi wrote:
> > From: Dmitry Krivenok
> >
> > Added explicit check of MAC address specified via macaddr option.
> > Multicast MAC addresses are no longer allowed.
> > This fixes bug l
On Fri, Oct 18, 2013 at 03:35:14PM +0200, Stefan Hajnoczi wrote:
> From: Dmitry Krivenok
>
> Added explicit check of MAC address specified via macaddr option.
> Multicast MAC addresses are no longer allowed.
> This fixes bug lp#495566.
>
> Signed-off-by: Dmitry V. Krivenok
> Signed-off-by: Stef
From: Dmitry Krivenok
Added explicit check of MAC address specified via macaddr option.
Multicast MAC addresses are no longer allowed.
This fixes bug lp#495566.
Signed-off-by: Dmitry V. Krivenok
Signed-off-by: Stefan Hajnoczi
---
net/net.c | 5 +
net/util.c | 5 +
net/util.h | 2 ++
