Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2016 at 03:06:09PM +0200, Maxime Coquelin wrote: > > > On 09/02/2016 07:29 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 02, 2016 at 10:57:17AM +0200, Maxime Coquelin wrote: > > > > > > > > > On 09/01/2016 03:46 PM, Michael S. Tsirkin wrote: > > > > On Wed, Aug 31, 2016 at 01:19

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-05 Thread Maxime Coquelin
On 09/02/2016 07:29 PM, Michael S. Tsirkin wrote: On Fri, Sep 02, 2016 at 10:57:17AM +0200, Maxime Coquelin wrote: On 09/01/2016 03:46 PM, Michael S. Tsirkin wrote: On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: On 08/14/2016 11:42 AM, Prerna Saxena wrote: On 14/08/16

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-02 Thread Michael S. Tsirkin
On Fri, Sep 02, 2016 at 10:57:17AM +0200, Maxime Coquelin wrote: > > > On 09/01/2016 03:46 PM, Michael S. Tsirkin wrote: > > On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: > > > > > > > > > On 08/14/2016 11:42 AM, Prerna Saxena wrote: > > > > On 14/08/16 8:21 am, "Michael S. T

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-02 Thread Maxime Coquelin
On 09/01/2016 03:46 PM, Michael S. Tsirkin wrote: On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: On 08/14/2016 11:42 AM, Prerna Saxena wrote: On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: On 12/08/16 1

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-09-01 Thread Michael S. Tsirkin
On Wed, Aug 31, 2016 at 01:19:47PM +0200, Maxime Coquelin wrote: > > > On 08/14/2016 11:42 AM, Prerna Saxena wrote: > > On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: > > > > > > > On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: > > > > > > > > On 12/08/16 12:08 pm, "Fam Zhen

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-31 Thread Maxime Coquelin
On 08/14/2016 11:42 AM, Prerna Saxena wrote: On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: On 12/08/16 12:08 pm, "Fam Zheng" wrote: On Wed, 08/10 18:30, Michael S. Tsirkin wrote: From: Prerna Saxena The set_mem_ta

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-15 Thread Peter Maydell
On 12 August 2016 at 16:49, Michael S. Tsirkin wrote: > On Fri, Aug 12, 2016 at 01:01:16PM +0100, Peter Maydell wrote: >> If somebody would like to send a revert-patch to the list I'll apply >> it to master (please cc me as I suspect the mailing list server is >> down at the moment...) I've been s

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2016 at 09:42:11AM +, Prerna Saxena wrote: > On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: > > > >On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: > >> > >> On 12/08/16 12:08 pm, "Fam Zheng" wrote: > >> > >> > >> > >> > >> > >> >On Wed, 08/10 18:30, Mi

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-14 Thread Prerna Saxena
On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: >On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: >> >> On 12/08/16 12:08 pm, "Fam Zheng" wrote: >> >> >> >> >> >> >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: >> >> From: Prerna Saxena >> >> >> >> The set_mem_table comma

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-13 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: > > On 12/08/16 12:08 pm, "Fam Zheng" wrote: > > > > > > >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: > >> From: Prerna Saxena > >> > >> The set_mem_table command currently does not seek a reply. Hence, there is > >> no easy

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-13 Thread Michael S. Tsirkin
On Sat, Aug 13, 2016 at 02:13:46AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Aug 12, 2016 at 11:54:54AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wro

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-13 Thread Michael S. Tsirkin
On Sat, Aug 13, 2016 at 02:13:46AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Aug 12, 2016 at 11:54:54AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wro

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Aug 12, 2016 at 11:54:54AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > > > Hi > > > > > > > > - Original Message - > > > > > sent a follo

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 11:54:54AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > sent a follow-up response to GET_FEATURES), I am now wondering

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Prerna Saxena
On 12/08/16 12:08 pm, "Fam Zheng" wrote: >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: >> From: Prerna Saxena >> >> The set_mem_table command currently does not seek a reply. Hence, there is >> no easy way for a remote application to notify to QEMU when it finished >> setting up memory,

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 01:01:16PM +0100, Peter Maydell wrote: > On 12 August 2016 at 08:20, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> sent a follow-up response to GET_FEATURES), I am now wondering if this > >> patch > >> may break existing vhost applications too ?

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > > may break existing vhost applications too ? If so, reverting it possibly > > better. > > What confuses me is

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > sent a follow-up response to GET_FEATURES), I am now wondering if this > > > patch > > > may break existing vhost applications too ? If so, revert

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > may break existing vhost applications too ? If so, reverting it possibly > better. > What confuses me is why it doesn’t fail all the time, but only about 20% to > 30% time as Fam report

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 08:20, Marc-André Lureau wrote: > Hi > > - Original Message - >> sent a follow-up response to GET_FEATURES), I am now wondering if this patch >> may break existing vhost applications too ? If so, reverting it possibly >> better. >> What confuses me is why it doesn’t fa

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-11 Thread Fam Zheng
On Wed, 08/10 18:30, Michael S. Tsirkin wrote: > From: Prerna Saxena > > The set_mem_table command currently does not seek a reply. Hence, there is > no easy way for a remote application to notify to QEMU when it finished > setting up memory, or if there were errors doing so. > > As an example:

[Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-10 Thread Michael S. Tsirkin
From: Prerna Saxena The set_mem_table command currently does not seek a reply. Hence, there is no easy way for a remote application to notify to QEMU when it finished setting up memory, or if there were errors doing so. As an example: (1) Qemu sends a SET_MEM_TABLE to the backend (eg, a vhost-us