Re: [Qemu-devel] [PULL 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-02-14 Thread John Snow
On 2/14/19 10:46 AM, Eric Blake wrote: > On 2/13/19 5:49 PM, John Snow wrote: >> When bitmaps are persistent, they may incur a disk read or write when bitmaps >> are added or removed. For configurations like virtio-dataplane, failing to >> acquire this lock will abort QEMU when disk IO occurs. >

Re: [Qemu-devel] [PULL 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-02-14 Thread Eric Blake
On 2/13/19 5:49 PM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part of t

[Qemu-devel] [PULL 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-02-13 Thread John Snow
When bitmaps are persistent, they may incur a disk read or write when bitmaps are added or removed. For configurations like virtio-dataplane, failing to acquire this lock will abort QEMU when disk IO occurs. We used to acquire aio_context as part of the bitmap lookup, so re-introduce the lock for