Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-27 Thread Igor Mammedov
On Tue, 26 Jul 2016 16:19:28 -0300 Eduardo Habkost wrote: > On Tue, Jul 26, 2016 at 04:16:04PM +0200, Igor Mammedov wrote: > > On Tue, 26 Jul 2016 18:41:22 +0530 > > Amit Shah wrote: > > > > > On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote: > > > > > This was flagged by a nightly run

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Eduardo Habkost
On Tue, Jul 26, 2016 at 04:16:04PM +0200, Igor Mammedov wrote: > On Tue, 26 Jul 2016 18:41:22 +0530 > Amit Shah wrote: > > > On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote: > > > > This was flagged by a nightly run of the static checker when this > > > > series was pulled. On a 'before' tr

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Igor Mammedov
On Tue, 26 Jul 2016 18:41:22 +0530 Amit Shah wrote: > On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote: > > > This was flagged by a nightly run of the static checker when this > > > series was pulled. On a 'before' tree, ie one w/o the patches, do > > > this: > > > > > > qemu -dump-vmstate

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Igor Mammedov
On Tue, 26 Jul 2016 18:41:22 +0530 Amit Shah wrote: > On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote: > > > This was flagged by a nightly run of the static checker when this > > > series was pulled. On a 'before' tree, ie one w/o the patches, do > > > this: > > > > > > qemu -dump-vmstate

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Amit Shah
On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote: > > This was flagged by a nightly run of the static checker when this > > series was pulled. On a 'before' tree, ie one w/o the patches, do > > this: > > > > qemu -dump-vmstate before.json > > > > and for after: > > > > qemu -dump-vmstate af

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Igor Mammedov
On Tue, 26 Jul 2016 17:17:47 +0530 Amit Shah wrote: > On (Tue) 26 Jul 2016 [10:00:49], Igor Mammedov wrote: > > On Tue, 26 Jul 2016 10:41:38 +0530 > > Amit Shah wrote: > > > > > On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > > > > From: Igor Mammedov > > > > > > > > instance_id

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Amit Shah
On (Tue) 26 Jul 2016 [11:41:33], Igor Mammedov wrote: > On Tue, 26 Jul 2016 10:41:38 +0530 > Amit Shah wrote: > > > On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > > > From: Igor Mammedov > > > > > > instance_id is generated by last_used_id + 1 for a given device type > > > so for QEM

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Amit Shah
On (Tue) 26 Jul 2016 [10:00:49], Igor Mammedov wrote: > On Tue, 26 Jul 2016 10:41:38 +0530 > Amit Shah wrote: > > > On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > > > From: Igor Mammedov > > > > > > instance_id is generated by last_used_id + 1 for a given device type > > > so for QEM

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Igor Mammedov
On Tue, 26 Jul 2016 10:41:38 +0530 Amit Shah wrote: > On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > > From: Igor Mammedov > > > > instance_id is generated by last_used_id + 1 for a given device type > > so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] > > When CP

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-26 Thread Igor Mammedov
On Tue, 26 Jul 2016 10:41:38 +0530 Amit Shah wrote: > On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > > From: Igor Mammedov > > > > instance_id is generated by last_used_id + 1 for a given device type > > so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] > > When CP

Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-25 Thread Amit Shah
On (Wed) 20 Jul 2016 [12:08:32], Eduardo Habkost wrote: > From: Igor Mammedov > > instance_id is generated by last_used_id + 1 for a given device type > so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] > When CPU in the middle is hot-removed and migration started > APICs with

[Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-20 Thread Eduardo Habkost
From: Igor Mammedov instance_id is generated by last_used_id + 1 for a given device type so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] When CPU in the middle is hot-removed and migration started APICs with instance_ids 0 and 2 are transferred in migration stream. However ta

[Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id

2016-07-19 Thread Eduardo Habkost
From: Igor Mammedov instance_id is generated by last_used_id + 1 for a given device type so for QEMU with 3 CPUs instance_id for APICs is a seti of [0, 1, 2] When CPU in the middle is hot-removed and migration started APICs with instance_ids 0 and 2 are transferred in migration stream. However ta