Re: [Qemu-devel] [PULL 15/28] i8259: Convert to MemoryRegion

2011-09-12 Thread Jan Kiszka
On 2011-09-12 14:54, Jan Kiszka wrote: > On 2011-09-12 12:50, Avi Kivity wrote: >> From: Richard Henderson >> >> The only non-obvious part is pic_poll_read which used >> "addr1 >> 7" to detect whether one referred to either >> the master or slave PIC. Instead, test this directly. > > I've an unf

Re: [Qemu-devel] [PULL 15/28] i8259: Convert to MemoryRegion

2011-09-12 Thread Jan Kiszka
On 2011-09-12 12:50, Avi Kivity wrote: > From: Richard Henderson > > The only non-obvious part is pic_poll_read which used > "addr1 >> 7" to detect whether one referred to either > the master or slave PIC. Instead, test this directly. I've an unfinished queue here that, among other things, took

[Qemu-devel] [PULL 15/28] i8259: Convert to MemoryRegion

2011-09-12 Thread Avi Kivity
From: Richard Henderson The only non-obvious part is pic_poll_read which used "addr1 >> 7" to detect whether one referred to either the master or slave PIC. Instead, test this directly. Signed-off-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/i8259.c | 65 +