Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-20 Thread Michael S. Tsirkin
On Thu, Feb 20, 2014 at 09:22:46AM -0500, Gabriel L. Somlo wrote: > Hi Michael, > > On Thu, Feb 20, 2014 at 07:13:46AM +0200, Michael S. Tsirkin wrote: > > Oh yes, I forgot that Q35 has a separate DSDT. > > Please add this on top: > > Thanks, I can confirm that this patch > (ceb36090bf2054c8ad5c8

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-20 Thread Gabriel L. Somlo
Hi Michael, On Thu, Feb 20, 2014 at 07:13:46AM +0200, Michael S. Tsirkin wrote: > Oh yes, I forgot that Q35 has a separate DSDT. > Please add this on top: Thanks, I can confirm that this patch (ceb36090bf2054c8ad5c8cf441b690fad5581f4f) on top of a0ad25b1e5d0eb21cbba001799341bd6b557e995, on top of

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 02:45:29PM -0500, Gabriel L. Somlo wrote: > On Wed, Feb 19, 2014 at 09:02:15PM +0200, Michael S. Tsirkin wrote: > > On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > > > With this l

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Gabriel L. Somlo
On Wed, Feb 19, 2014 at 09:02:15PM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > > With this latest version of your patch, I crash during OS X boot with > > > "unable t

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 10:24:50AM -0500, Gabriel L. Somlo wrote: > On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > > > > > With this latest version of your patch, I crash during OS X boot with > > > "una

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > Michael, > > > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > > As reported in > > > http://article.gmane.org/gmane.comp.emulators.

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Alex Williamson
On Mon, 2014-02-17 at 09:51 -0500, Gabriel L. Somlo wrote: > Michael, > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > As reported in > > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > > Mac OSX actually requires describing all occupied slots > > in ACPI - e

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Gabriel L. Somlo
On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > > > With this latest version of your patch, I crash during OS X boot with > > "unable to find driver for this > > platform:\"ACPI\".\n"@/SourceCache/xnu/xnu-

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Wed, Feb 19, 2014 at 01:52:20PM +, Peter Maydell wrote: > On 17 February 2014 16:44, Michael S. Tsirkin wrote: > > Peter, if not too late, pls don't pull until we figure it out. > > If you want a pull request to not be applied you need to follow > up to the 00/nn cover letter for the pull

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Peter Maydell
On 17 February 2014 16:44, Michael S. Tsirkin wrote: > Peter, if not too late, pls don't pull until we figure it out. If you want a pull request to not be applied you need to follow up to the 00/nn cover letter for the pull request to say so. Otherwise I am likely to either miss the request or no

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-19 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > Michael, > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > As reported in > > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > > Mac OSX actually requires describing all occupied slots > > in A

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > Michael, > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > As reported in > > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > > Mac OSX actually requires describing all occupied slots > > in A

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Gabriel L. Somlo
Michael, On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > As reported in > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > Mac OSX actually requires describing all occupied slots > in ACPI - even if hotplug isn't enabled. > > I didn't expect this so I dropped desc

[Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Michael S. Tsirkin
As reported in http://article.gmane.org/gmane.comp.emulators.qemu/253987 Mac OSX actually requires describing all occupied slots in ACPI - even if hotplug isn't enabled. I didn't expect this so I dropped description of all non hotpluggable slots from ACPI. As a result: before commit 99fd437dee4686