Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set

2015-11-30 Thread Marcel Apfelbaum
On 11/29/2015 08:22 PM, Bandan Das wrote: Hi Marcel, Marcel Apfelbaum writes: ... Maybe is too late, but this contradicts QEMU usage, as I understand Why late ? We can always revert it :) Well, this is why I am so disappointment in myself that I didn't catch this earlier. I *really* don't

Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set

2015-11-29 Thread Bandan Das
Hi Marcel, Marcel Apfelbaum writes: ... > > Maybe is too late, but this contradicts QEMU usage, as I understand Why late ? We can always revert it :) > object_property_get_* should be used when we don't know object's type. My understanding is that it's not mandatory to use it only when type is u

Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set

2015-11-29 Thread Marcel Apfelbaum
On 11/19/2015 03:36 PM, Michael S. Tsirkin wrote: From: Bandan Das The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Bandan Das --- include

[Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set

2015-11-19 Thread Michael S. Tsirkin
From: Bandan Das The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Bandan Das --- include/hw/boards.h | 1 - hw/core/machine.c | 5 - hw