Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst

2014-09-23 Thread Richard Henderson
On 09/23/2014 11:42 AM, Paolo Bonzini wrote: > No, it just caught my eye because it'll conflict with the PPC patches > that have NB_MMU_MODES == 12. Ah, right, so it will. Peter, please don't pull. I'll drop that patch for now. r~

Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst

2014-09-23 Thread Paolo Bonzini
Il 23/09/2014 19:48, Peter Maydell ha scritto: > On 22 September 2014 23:19, Paolo Bonzini wrote: >> Il 22/09/2014 22:57, Richard Henderson ha scritto: >>> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32); >>> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8); >>> + >>> typedef struct TCGLabelQemuLdst { >>> -b

Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst

2014-09-23 Thread Peter Maydell
On 22 September 2014 23:19, Paolo Bonzini wrote: > Il 22/09/2014 22:57, Richard Henderson ha scritto: >> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32); >> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8); >> + >> typedef struct TCGLabelQemuLdst { >> -bool is_ld:1; /* qemu_ld: true, qemu_st: false

Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 22:57, Richard Henderson ha scritto: > +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32); > +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8); > + > typedef struct TCGLabelQemuLdst { > -bool is_ld:1; /* qemu_ld: true, qemu_st: false */ > -TCGMemOp opc:4; > -TCGReg addrlo_reg;

[Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst

2014-09-22 Thread Richard Henderson
Use 1 32-bit word instead of 6. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/tcg-be-ldst.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h index 49b3de6..904eeda 100644 --- a/tcg/tcg-be-ldst.