Re: [Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2018-05-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/05/2018 11:27, Peter Maydell wrote: >>> +uint8_t replay_get_byte(void) >>> +{ >>> +uint8_t byte = 0; >>> +if (replay_file) { >>> +byte = getc(replay_file); >>> +} >>> +return byte; >>> +} >> Coverity (CID 1390576) points out that this function

Re: [Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2018-05-11 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 11/05/2018 11:27, Peter Maydell wrote: > >> +uint8_t replay_get_byte(void) > >> +{ > >> +uint8_t byte = 0; > >> +if (replay_file) { > >> +byte = getc(replay_file); > >> +} > >> +return byte; > >> +} > > Coverity (CID 13

Re: [Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2018-05-11 Thread Paolo Bonzini
On 11/05/2018 11:27, Peter Maydell wrote: >> +uint8_t replay_get_byte(void) >> +{ >> +uint8_t byte = 0; >> +if (replay_file) { >> +byte = getc(replay_file); >> +} >> +return byte; >> +} > Coverity (CID 1390576) points out that this function isn't checking > the error return

Re: [Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2018-05-11 Thread Peter Maydell
On 5 November 2015 at 12:13, Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch adds functions to perform read and write operations > with replay log. > > Reviewed-by: Paolo Bonzini > +void replay_put_byte(uint8_t byte) > +{ > +if (replay_file) { > +putc(byte, replay_file);

[Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2015-11-05 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162342.8676.29445.st...@pasha-isp.def.inno> Signed-off-by: Paolo Bonzini --- replay/Makefile.objs | 1 +

[Qemu-devel] [PULL 02/18] replay: internal functions for replay log

2015-11-04 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162342.8676.29445.st...@pasha-isp.def.inno> Signed-off-by: Paolo Bonzini --- replay/Makefile.objs | 1 +