Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-03-07 Thread Jason Wang
On 03/07/2016 07:36 PM, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote: >> Part of the codes looks duplicated with ipv4 version. Any chances to >> merge them like tcp? > The duplication is actually quite small: accessing the ip length > is different, filling the add

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote: > Part of the codes looks duplicated with ipv4 version. Any chances to > merge them like tcp? The duplication is actually quite small: accessing the ip length is different, filling the address is different, etc. So there are differences all al

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-03-06 Thread Jason Wang
On 02/23/2016 03:28 AM, Samuel Thibault wrote: > From: Guillaume Subiron > > This adds the sin6 case in the fhost and lhost unions and related macros. > It adds udp6_input() and udp6_output(). > It adds the IPv6 case in sorecvfrom(). > Finally, udp_input() is called by ip6_input(). > > Signed-of

[Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-02-22 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Review