Jason Wang, on Tue 08 Mar 2016 10:15:57 +0800, wrote:
> Build works but get some warnings:
>
>
> slirp/ip6_icmp.c: In function 'icmp6_send_error':
> slirp/ip6_icmp.c:84:5: warning: implicit declaration of function
> 'inet_ntop' [-Wimplicit-function-declaration]
> inet_ntop(AF_INET6, &rip->ip
Jason Wang, on Tue 08 Mar 2016 10:48:27 +0800, wrote:
> ./scripts/checkpatch.pl
> 0001-slirp-Adding-IPv6-ICMPv6-Echo-and-NDP-autoconfigurat.patch
> ERROR: return is not a function, parentheses are not required
> #177: FILE: slirp/ip6.h:65:
> +return (a->s6_addr[prefix_len / 8] & ((1U << (8 - (p
On 03/07/2016 08:16 PM, Jan Kiszka wrote:
> On 2016-03-07 13:14, Thomas Huth wrote:
>> On 07.03.2016 13:06, Jan Kiszka wrote:
>>> On 2016-03-07 12:09, Samuel Thibault wrote:
Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
> Btw, do you want to be the maintainer of slirp? (Or maybe
On 03/07/2016 07:19 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - Lots of checkpatch warnings, let's try to silent it.
> They are indentation issues, yes. They are already existing in slirp/
> . Whenever new code was added we sticked with the qemu style,
On 03/07/2016 07:55 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - the series does not build on w32:
>> In file included from ./slirp/slirp.h:126:0,
>> from stubs/slirp.c:3:
>> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or
On 03/07/2016 07:09 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
>> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
>> do this?)
> I already said I was fine with it, yes, and submitted a MAINTAINERS
> patch towards that, without any r
Hello,
Thomas Huth, on Mon 07 Mar 2016 16:37:59 +0100, wrote:
> Is that "#include " required in ip6.h at all? It also seems
> to compile if I omit that include completely here...
Well, it makes sense to put it in ip6.h. That said, since ip6.h is only
included through slirp.h which includes netin
On 07.03.2016 12:55, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - the series does not build on w32:
>> In file included from ./slirp/slirp.h:126:0,
>> from stubs/slirp.c:3:
>> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or dire
Thomas Huth, on Mon 07 Mar 2016 13:00:48 +0100, wrote:
> On 07.03.2016 12:19, Samuel Thibault wrote:
> > Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
> >> - I expects a unit-test for this. You may want to have a look at the
> >> pxe-test in tests/, I think it could be extended to test ipv6
On 2016-03-07 13:14, Thomas Huth wrote:
> On 07.03.2016 13:06, Jan Kiszka wrote:
>> On 2016-03-07 12:09, Samuel Thibault wrote:
>>> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
do this?)
>>>
>>> I already sa
On 07.03.2016 13:06, Jan Kiszka wrote:
> On 2016-03-07 12:09, Samuel Thibault wrote:
>> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
>>> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
>>> do this?)
>>
>> I already said I was fine with it, yes, and submitted a MAIN
Jan Kiszka, on Mon 07 Mar 2016 13:06:20 +0100, wrote:
> On 2016-03-07 12:09, Samuel Thibault wrote:
> > Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
> >> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
> >> do this?)
> >
> > I already said I was fine with it, yes,
On 2016-03-07 12:09, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
>> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
>> do this?)
>
> I already said I was fine with it, yes, and submitted a MAINTAINERS
> patch towards that, without any res
On 07.03.2016 12:19, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - Lots of checkpatch warnings, let's try to silent it.
>
> They are indentation issues, yes. They are already existing in slirp/
> . Whenever new code was added we sticked with the qemu style, bu
Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
> - the series does not build on w32:
> In file included from ./slirp/slirp.h:126:0,
> from stubs/slirp.c:3:
> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directory
Is it the only issue? Does it build if you
Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
> - Lots of checkpatch warnings, let's try to silent it.
They are indentation issues, yes. They are already existing in slirp/
. Whenever new code was added we sticked with the qemu style, but for
patched code we prefered to stick to the existi
Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote:
> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to
> do this?)
I already said I was fine with it, yes, and submitted a MAINTAINERS
patch towards that, without any response.
Samuel
On 02/23/2016 03:28 AM, Samuel Thibault wrote:
> Hello,
>
> This is another respin of IPv6 in Qemu -net user mode.
>
>
> These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add
> TFTP over IPv6.
>
Thanks a lot for the patches. Looks good overall, but see some issues:
- the
On 03/07/2016 12:59 AM, Samuel Thibault wrote:
> Hello,
>
> Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote:
>> On 2016-03-04 09:41, Thomas Huth wrote:
>>> On 22.02.2016 20:28, Samuel Thibault wrote:
Hello,
This is another respin of IPv6 in Qemu -net user mode.
These
Hello,
Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote:
> On 2016-03-04 09:41, Thomas Huth wrote:
> > On 22.02.2016 20:28, Samuel Thibault wrote:
> >> Hello,
> >>
> >> This is another respin of IPv6 in Qemu -net user mode.
> >>
> >> These patches add ICMPv6, NDP, make UDP and TCP compatible w
On 2016-03-04 09:41, Thomas Huth wrote:
> On 22.02.2016 20:28, Samuel Thibault wrote:
>> Hello,
>>
>> This is another respin of IPv6 in Qemu -net user mode.
>>
>> These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add
>> TFTP over IPv6.
>
> *ping*
>
> Jan, Jason,
>
> coul
On 22.02.2016 20:28, Samuel Thibault wrote:
> Hello,
>
> This is another respin of IPv6 in Qemu -net user mode.
>
> These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add
> TFTP over IPv6.
*ping*
Jan, Jason,
could you please have a look at this series? Would be cool to
Hello,
This is another respin of IPv6 in Qemu -net user mode.
These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add
TFTP over IPv6.
Difference with version 8 is:
- Fix freeing random number generator
- Fix coding style
- Fix prefix lengths in in6_equal_dns macro
Here i
23 matches
Mail list logo
