Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-16 Thread Thomas Huth
On 14.02.2016 18:47, Samuel Thibault wrote: > From: Guillaume Subiron > > This adds the sin6 case in the fhost and lhost unions and related macros. > It adds udp6_input() and udp6_output(). > It adds the IPv6 case in sorecvfrom(). > Finally, udp_input() is called by ip6_input(). > > Signed-off-b

[Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-14 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- s

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-09 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 08:18:45 +0100, wrote: > On 09.02.2016 22:19, Samuel Thibault wrote: > > Thanks for your reviews so far! I have integrated the rest of comments, > > the only remaining question for patches 1-3 is about srand() and rand(). > > I personally don't mind whether you use

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-09 Thread Thomas Huth
On 09.02.2016 22:19, Samuel Thibault wrote: > Thanks for your reviews so far! I have integrated the rest of comments, > the only remaining question for patches 1-3 is about srand() and rand(). I personally don't mind whether you use rand(), g_random_int_range() or g_rand_int_range() here, but of

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-09 Thread Samuel Thibault
Thanks for your reviews so far! I have integrated the rest of comments, the only remaining question for patches 1-3 is about srand() and rand(). Samuel

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-09 Thread Samuel Thibault
Thomas Huth, on Tue 09 Feb 2016 21:44:18 +0100, wrote: > > + case AF_INET6: > > + udp6_output(so, m, (struct sockaddr_in6 *) &saddr, > > + (struct sockaddr_in6 *) &daddr); > > + break; > > default: > > + g_assert_not_reached(); > >

Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-09 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This adds the sin6 case in the fhost and lhost unions and related macros. > It adds udp6_input() and udp6_output(). > It adds the IPv6 case in sorecvfrom(). > Finally, udp_input() is called by ip6_input(). > > Signed-off-b

[Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- s