Re: [Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages

2013-03-25 Thread Orit Wasserman
On 03/22/2013 02:46 PM, Peter Lieven wrote: > virtually all dup pages are zero pages. remove > the special is_dup_page() function and use the > optimized buffer_find_nonzero_offset() function > instead. > > here buffer_find_nonzero_offset() is used directly > to avoid the unnecssary additional che

Re: [Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages

2013-03-22 Thread Peter Lieven
Am 22.03.2013 20:49, schrieb Eric Blake: > On 03/22/2013 06:46 AM, Peter Lieven wrote: >> virtually all dup pages are zero pages. remove >> the special is_dup_page() function and use the >> optimized buffer_find_nonzero_offset() function >> instead. >> >> here buffer_find_nonzero_offset() is used d

Re: [Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages

2013-03-22 Thread Eric Blake
On 03/22/2013 06:46 AM, Peter Lieven wrote: > virtually all dup pages are zero pages. remove > the special is_dup_page() function and use the > optimized buffer_find_nonzero_offset() function > instead. > > here buffer_find_nonzero_offset() is used directly > to avoid the unnecssary additional che

[Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages

2013-03-22 Thread Peter Lieven
virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized buffer_find_nonzero_offset() function instead. here buffer_find_nonzero_offset() is used directly to avoid the unnecssary additional checks in buffer_is_zero(). raw performace gain checking zer