Re: [Qemu-devel] [PATCHv4 4/8] pseries: Cleanup error handling in spapr_vga_init()

2016-01-18 Thread Alexey Kardashevskiy
On 01/19/2016 02:39 PM, David Gibson wrote: Use error_setg() to return an error rather than an explicit exit(). Previously it was an exit(0) instead of a non-zero exit code, which was simply a bug. Also improve the error message. While we're at it change the type of spapr_vga_init() to bool sin

[Qemu-devel] [PATCHv4 4/8] pseries: Cleanup error handling in spapr_vga_init()

2016-01-18 Thread David Gibson
Use error_setg() to return an error rather than an explicit exit(). Previously it was an exit(0) instead of a non-zero exit code, which was simply a bug. Also improve the error message. While we're at it change the type of spapr_vga_init() to bool since that's how we're using it anyway. Signed-o