Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

2016-01-18 Thread David Gibson
On Mon, Jan 18, 2016 at 10:31:42AM +0100, Thomas Huth wrote: > On 18.01.2016 05:24, David Gibson wrote: > > This function includes a number of explicit fprintf()s for errors. > > Change these to use error_report() instead. > > > > Also replace the single exit(EXIT_FAILURE) with an explicit exit(1)

Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

2016-01-18 Thread Markus Armbruster
Thomas Huth writes: > On 18.01.2016 05:24, David Gibson wrote: >> This function includes a number of explicit fprintf()s for errors. >> Change these to use error_report() instead. >> >> Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since >> the latter is the more usual idi

Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

2016-01-18 Thread Thomas Huth
On 18.01.2016 05:24, David Gibson wrote: > This function includes a number of explicit fprintf()s for errors. > Change these to use error_report() instead. > > Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since > the latter is the more usual idiom in qemu by a large margin.

[Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

2016-01-17 Thread David Gibson
This function includes a number of explicit fprintf()s for errors. Change these to use error_report() instead. Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since the latter is the more usual idiom in qemu by a large margin. Signed-off-by: David Gibson --- hw/ppc/spapr.c