Re: [Qemu-devel] [PATCHv3 2/7] pnv: Fix some error handling cpu realize()

2018-06-13 Thread Greg Kurz
On Thu, 14 Jun 2018 14:41:24 +1000 David Gibson wrote: > In pnv_core_realize() we call two functions with an Error * parameter in > succession, which will go badly if they both cause errors. In fact, a > failure in either of them indicates a qemu internal error, so we can just > use &error_abort

Re: [Qemu-devel] [PATCHv3 2/7] pnv: Fix some error handling cpu realize()

2018-06-13 Thread Cédric Le Goater
On 06/14/2018 06:41 AM, David Gibson wrote: > In pnv_core_realize() we call two functions with an Error * parameter in > succession, which will go badly if they both cause errors. In fact, a > failure in either of them indicates a qemu internal error, so we can just > use &error_abort in both case

[Qemu-devel] [PATCHv3 2/7] pnv: Fix some error handling cpu realize()

2018-06-13 Thread David Gibson
In pnv_core_realize() we call two functions with an Error * parameter in succession, which will go badly if they both cause errors. In fact, a failure in either of them indicates a qemu internal error, so we can just use &error_abort in both cases. Signed-off-by: David Gibson --- hw/ppc/pnv_cor