Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Peter Lieven
Am 10.07.2013 16:58, schrieb Kevin Wolf: > Am 10.07.2013 um 16:49 hat Peter Lieven geschrieben: >> Am 10.07.2013 16:28, schrieb Kevin Wolf: >>> Am 10.07.2013 um 16:04 hat Peter Lieven geschrieben: Am 10.07.2013 13:33, schrieb Kevin Wolf: > Am 27.06.2013 um 15:11 hat Peter Lieven geschriebe

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Kevin Wolf
Am 10.07.2013 um 16:49 hat Peter Lieven geschrieben: > Am 10.07.2013 16:28, schrieb Kevin Wolf: > > Am 10.07.2013 um 16:04 hat Peter Lieven geschrieben: > >> Am 10.07.2013 13:33, schrieb Kevin Wolf: > >>> Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: > if the target does not support UNM

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Peter Lieven
Am 10.07.2013 16:28, schrieb Kevin Wolf: > Am 10.07.2013 um 16:04 hat Peter Lieven geschrieben: >> Am 10.07.2013 13:33, schrieb Kevin Wolf: >>> Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: if the target does not support UNMAP or the request is too big silently ignore the discard r

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Kevin Wolf
Am 10.07.2013 um 16:04 hat Peter Lieven geschrieben: > Am 10.07.2013 13:33, schrieb Kevin Wolf: > > Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: > >> if the target does not support UNMAP or the request > >> is too big silently ignore the discard request. > >> > >> Signed-off-by: Peter Lieve

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Peter Lieven
Am 10.07.2013 13:33, schrieb Kevin Wolf: > Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: >> if the target does not support UNMAP or the request >> is too big silently ignore the discard request. >> >> Signed-off-by: Peter Lieven > Why not loop for the "too big" case? You can probably use th

Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-07-10 Thread Kevin Wolf
Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: > if the target does not support UNMAP or the request > is too big silently ignore the discard request. > > Signed-off-by: Peter Lieven Why not loop for the "too big" case? You can probably use the same logic for unmapping the whole device in

[Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported

2013-06-27 Thread Peter Lieven
if the target does not support UNMAP or the request is too big silently ignore the discard request. Signed-off-by: Peter Lieven --- block/iscsi.c |8 1 file changed, 8 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index e9ecfce..0567b46 100644 --- a/block/iscsi.c +++ b/b