Re: [Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-21 Thread Jason Wang
On 2016年06月21日 18:11, Paolo Bonzini wrote: On 21/06/2016 11:36, David Vrabel wrote: >On 21/06/16 08:35, Paolo Bonzini wrote: >> >> >>On 21/06/2016 03:44, Jason Wang wrote: >>> >>> >>>On 2016年06月21日 01:53, David Vrabel wrote: Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port

Re: [Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-21 Thread Paolo Bonzini
On 21/06/2016 11:36, David Vrabel wrote: > On 21/06/16 08:35, Paolo Bonzini wrote: >> >> >> On 21/06/2016 03:44, Jason Wang wrote: >>> >>> >>> On 2016年06月21日 01:53, David Vrabel wrote: Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port TallyCounters to vmstate) introduced in

Re: [Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-21 Thread David Vrabel
On 21/06/16 08:35, Paolo Bonzini wrote: > > > On 21/06/2016 03:44, Jason Wang wrote: >> >> >> On 2016年06月21日 01:53, David Vrabel wrote: >>> Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port >>> TallyCounters to vmstate) introduced in incompatibility in the v4 >>> format as it omitted

Re: [Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-21 Thread Paolo Bonzini
On 21/06/2016 03:44, Jason Wang wrote: > > > On 2016年06月21日 01:53, David Vrabel wrote: >> Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port >> TallyCounters to vmstate) introduced in incompatibility in the v4 >> format as it omitted the RxOkMul counter. >> >> There are presumably n

Re: [Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-20 Thread Jason Wang
On 2016年06月21日 01:53, David Vrabel wrote: Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port TallyCounters to vmstate) introduced in incompatibility in the v4 format as it omitted the RxOkMul counter. There are presumably no users that were impacted by the v4 to v4' breakage, so in

[Qemu-devel] [PATCHv2] rtl8139: save/load RxMulOk counter (again)

2016-06-20 Thread David Vrabel
Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port TallyCounters to vmstate) introduced in incompatibility in the v4 format as it omitted the RxOkMul counter. There are presumably no users that were impacted by the v4 to v4' breakage, so increase the save version to 5 and re-add the fi