Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 12:13:18PM +0300, Gleb Natapov wrote: > On Sun, Apr 01, 2012 at 12:06:16PM +0300, Michael S. Tsirkin wrote: > > On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > > > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > > > And if pci-hotplu

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 12:06:16PM +0300, Michael S. Tsirkin wrote: > On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > > > pci-ho

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Michael S. Tsirkin
On Sun, Apr 01, 2012 at 11:26:18AM +0300, Gleb Natapov wrote: > On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > > pci-hotplug > > > (guest would only need to read PCI_BASE) and probably it would b

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Michael S. Tsirkin
On Fri, Mar 30, 2012 at 06:05:26PM +0200, Igor Mammedov wrote: > On 03/29/2012 02:51 PM, Michael S. Tsirkin wrote: > >piix acpi interface suffers from the following 2 issues: > > > >1. > >- delete device a > >- quickly add device b in another slot > > > >if we do this before guest reads the down re

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-04-01 Thread Gleb Natapov
On Sun, Apr 01, 2012 at 11:22:33AM +0300, Michael S. Tsirkin wrote: > > And if pci-hotplug could be done as cpu-hotplug, then it would simplify > > pci-hotplug > > (guest would only need to read PCI_BASE) and probably it would be possible > > to unify hotplug > > code for pci/cpu. But that for su

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-30 Thread Igor Mammedov
On 03/29/2012 02:51 PM, Michael S. Tsirkin wrote: piix acpi interface suffers from the following 2 issues: 1. - delete device a - quickly add device b in another slot if we do this before guest reads the down register, the down event is discarded and device will never be deleted. 2. - delete d

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-30 Thread Michael S. Tsirkin
On Thu, Mar 29, 2012 at 01:52:31PM -0600, Alex Williamson wrote: > On Thu, 2012-03-29 at 21:38 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 29, 2012 at 10:53:38AM -0600, Alex Williamson wrote: > > > On Thu, 2012-03-29 at 14:51 +0200, Michael S. Tsirkin wrote: > > > > piix acpi interface suffers

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Michael S. Tsirkin
On Thu, Mar 29, 2012 at 10:53:38AM -0600, Alex Williamson wrote: > On Thu, 2012-03-29 at 14:51 +0200, Michael S. Tsirkin wrote: > > piix acpi interface suffers from the following 2 issues: > > > > 1. > > - delete device a > > - quickly add device b in another slot > > > > if we do this before gue

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Alex Williamson
On Thu, 2012-03-29 at 21:38 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 29, 2012 at 10:53:38AM -0600, Alex Williamson wrote: > > On Thu, 2012-03-29 at 14:51 +0200, Michael S. Tsirkin wrote: > > > piix acpi interface suffers from the following 2 issues: > > > > > > 1. > > > - delete device a > >

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Alex Williamson
On Thu, 2012-03-29 at 14:51 +0200, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will never >

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Michael S. Tsirkin
On Thu, Mar 29, 2012 at 03:04:12PM +0200, Gleb Natapov wrote: > On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote: > > piix acpi interface suffers from the following 2 issues: > > > > 1. > > - delete device a > > - quickly add device b in another slot > > > > if we do this before

Re: [Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Gleb Natapov
On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will

[Qemu-devel] [PATCHv2] piix: fix up/down races + document

2012-03-29 Thread Michael S. Tsirkin
piix acpi interface suffers from the following 2 issues: 1. - delete device a - quickly add device b in another slot if we do this before guest reads the down register, the down event is discarded and device will never be deleted. 2. - delete device a - quickly reset before guest can respond in